error handling and add custom keyboard key listener#19
error handling and add custom keyboard key listener#19recepkoseoglu wants to merge 1 commit intoGoddchen:mainfrom
Conversation
|
I get an error: |
Goddchen
left a comment
Goddchen
left a comment
There was a problem hiding this comment.
suggestion: I'd also suggest to issue PRs that only tackle one feature / bug / issue per PR. Makes the whole process easier.
| ), | ||
| ), | ||
| (final SendPort sendPort) { | ||
| num x = details.localPosition.dx / |
There was a problem hiding this comment.
| num x = details.localPosition.dx / | |
| final num x = details.localPosition.dx / |
| num x = details.localPosition.dx / | ||
| _remoteFrameBufferWidgetSize.width * | ||
| _image.width; | ||
| num y = details.localPosition.dy / |
There was a problem hiding this comment.
| num y = details.localPosition.dy / | |
| final num y = details.localPosition.dy / |
| ), | ||
| ), | ||
| (final SendPort sendPort) { | ||
| num x = details.localPosition.dx / |
There was a problem hiding this comment.
| num x = details.localPosition.dx / | |
| final num x = details.localPosition.dx / |
| num x = details.localPosition.dx / | ||
| _remoteFrameBufferWidgetSize.width * | ||
| _image.width; | ||
| num y = details.localPosition.dy / |
There was a problem hiding this comment.
| num y = details.localPosition.dy / | |
| final num y = details.localPosition.dy / |
| ); | ||
| } | ||
|
|
||
| void _rawKeyEventListener(final RawKeyEvent rawKeyEvent) { |
There was a problem hiding this comment.
format: I prefer those one-liners to be expression methods.
| hostname: initMessage.hostName, | ||
| password: initMessage.password.toNullable(), | ||
| port: initMessage.port, | ||
| timeout: initMessage.timeout, |
There was a problem hiding this comment.
question: the current client implementation does not have a timeout parameter. Are you planing on creating a PR in that project as well?
| required final String hostName, | ||
| required final Option<String> password, | ||
| required final int port, | ||
| required final Duration? timeout, |
There was a problem hiding this comment.
suggestion: I want to avoid all null-aware code in this package. My suggestion would be to make this an Option<Duration> instead.
| final Option<String> _password; | ||
| final int _port; | ||
| final Option<ValueNotifier<Map<String, dynamic>>> _keyEventNotifier; | ||
| final Option<bool> _monitorClipBoard; |
There was a problem hiding this comment.
suggestion: can't this be a simple bool? Makes the using code a lot shorter and more readable as well.
| final void Function(Object error)? onError, | ||
| final String? password, | ||
| final int port = 5900, | ||
| final ValueNotifier<Map<String, dynamic>>? keyEventNotifier, |
There was a problem hiding this comment.
question: is it a usecase that you need right now? Knowing from outside of this widget, which keys are being pressed? I'd expect that you would just add a surrounding RawKeyboardListener widget (https://api.flutter.dev/flutter/widgets/RawKeyboardListener-class.html) to achieve this.
| (final ValueNotifier<Map<String, dynamic>> notifier) { | ||
| final Map<String, dynamic> event = notifier.value; | ||
| final LogicalKeyboardKey keyboardKey = event['keyboardKey']; | ||
| sendPort.send( |
There was a problem hiding this comment.
question: aren't we sending key events twice now?
3 participants
No description provided.