fix(streaming-widget): finalize bounty coverage and evidence by edehvictor · Pull Request #38 · GoodDollar/GoodWidget

edehvictor · 2026-05-21T01:45:21Z

Refs #26
Refs #28
Refs #36
Builds on AI PR #31.

Summary

Finalizes the streaming widget bounty work on top of the existing AI PR branch by filling the missing runtime states, deterministic Storybook coverage, Playwright coverage, and screenshot evidence needed for human review.

Changes

Kept the widget shell on WidgetTabs for Streams, Pools, and Balances.
Added deterministic StreamingWidgetPreview wiring for Storybook and Playwright while preserving the live StreamingWidget adapter path.
Added stream history state to the runtime contract, adapter, and UI, including loading, empty, error, populated, and Show more states.
Added live GDA pool claim support by reading getClaimableNow from pool contracts and submitting claimAll, with separate pending/success/error state.
Strengthened create/update stream UI for invalid input, disconnected wallet, wrong chain, pending, success, and failure states.
Preserved injected wallet and custodial fixture stories, and added deterministic stories for loading, empty, error, create/update, pool claim, Base SUP balance/reserve, and non-Base reserve-disabled states.
Replaced the streaming-widget Playwright smoke tests with deterministic coverage for tab navigation, stream filters/history, create/update success/failure, pool claim state, reserve visibility by chain, and mobile/desktop layout evidence.
Added current screenshot evidence under tests/widgets/streaming-widget/test-results/.
Fixed small pre-existing lint blockers outside the widget package so the required full pnpm lint command passes.

Verification

pnpm install: Passed
pnpm build: Passed
pnpm lint: Passed with existing repo warnings only
pnpm test:demo tests/widgets/streaming-widget: Passed, 13/13 tests
git diff --check HEAD~2..HEAD: Passed, no whitespace errors

Evidence

Playwright screenshots are committed in tests/widgets/streaming-widget/test-results/ and cover:

disconnected wallet
tab navigation
wrong chain
loading, empty, error, and populated stream/history states
create/update invalid, pending, success, and failure states
pool claim idle, pending, success, and error states
Base SUP reserve and non-Base reserve-disabled states
mobile and desktop populated layouts

Notes

This PR intentionally targets copilot/create-streaming-widget so AI PR #31 can be updated before maintainer review.

edehvictor · 2026-05-21T01:51:54Z

Hi @L03TJ3, PR #38 is ready for review.

I followed the assigned bounty flow, built on top of the existing AI branch, posted the handoff on #36, and included verification/evidence.

Verified:

pnpm install
pnpm build
pnpm lint
pnpm test:demo tests/widgets/streaming-widget passing, 13/13

Thanks again for assigning this.

pheobeayo · 2026-05-25T13:24:33Z

-      setStreams(result.map((s) => toStreamListItem(s, address as Address)))
+      const normalizedStreams = result.map((s) => toStreamListItem(s, address as Address))
+      setStreams(normalizedStreams)
+      setStreamHistory(normalizedStreams)


Nice work wiring up the history state machine; the loading/empty/error/populated states all render correctly. One thing worth flagging for a follow-up: setStreamHistory here is receiving the same result as setStreams, because getActiveStreams only returns currently active (non-zero flowRate) streams. Terminated streams would need a separate subgraph query, something like a getPastStreams or getStreamHistory call, to populate a true history list. As it stands, the history section in the UI is showing the same data as the active streams list, and the "Show more" pagination is working against that same pool. Not blocking for this bounty since the UI states are all covered, but worth picking up as a follow-up so the history tab reflects actual past streams.

Thanks, agreed. I kept this as a follow-up because the current SDK path only exposes active streams here, and added a fixture note so the Storybook history data is easy to split once a dedicated past-stream query exists.

pheobeayo · 2026-05-25T13:26:33Z

      connect,
      switchChain,
      refreshStreams: fetchStreams,
+      refreshStreamHistory: fetchStreams,


Small note to go alongside the history comment above, refreshStreamHistory is pointing to fetchStreams here, so both refresh actions hit the same underlying call. When a dedicated history fetch is added, this line will need to point to the new callback. Easy to update then

Agreed. Leaving refreshStreamHistory pointed at the current SDK-backed fetch for now; when a dedicated history callback lands this should switch to that separate fetch.

pheobeayo · 2026-05-25T13:29:50Z

+      const poolsWithClaimable = await Promise.all(
+        normalizedPools.map(async (pool) => {
+          try {
+            const [claimableAmount] = await viemClients.publicClient.readContract({
+              address: pool.poolId,
+              abi: GDA_POOL_CLAIM_ABI,
+              functionName: 'getClaimableNow',
+              args: [address as Address],
+            })
+
+            return {
+              ...pool,
+              claimableAmount: claimableAmount > 0n ? claimableAmount : 0n,
+            }


The getClaimableNow read looks good, and the claimableAmount > 0n guard correctly handles the signed int256 return. One thing to watch: if this readContract call throws (RPC timeout, contract revert, etc.), the catch silently returns the pool with claimableAmount still at 0n from the toPoolMembershipItem fallback. In the UI, that makes the Claim button appear disabled with no explanation. A user with a real claimable balance would just see a greyed-out button and have no way to tell whether it's a data error or genuinely nothing to claim. Could we add a claimableAmountError flag to PoolMembershipItem and surface a small "Could not load claimable amount, tap to retry" note in PoolCard when the read fails?

Fixed in 3494404: PoolMembershipItem now carries claimableAmountError, successful reads clear it, and failed getClaimableNow reads set it instead of silently falling back to an unexplained 0n state.

pheobeayo · 2026-05-25T13:35:44Z

+        !state.streamHistoryError &&
+        recentStreams.length === 0 && (
+          <EmptyStateCard>
+            <Text secondary center>


This is the UI side of the silent-failure issue flagged in the adapter's getClaimableNow catch block. When that read fails, claimableAmount stays at 0n, so canClaim is false and the button renders disabled with no explanation. Pairing this with the adapter fix, surfacing a claimableAmountError on the pool item, would let us show something like "Could not load claimable amount" here instead of just a greyed-out button.

Fixed in 3494404: PoolCard now surfaces the claimable amount load failure with a small inline “Could not load claimable amount. Tap to retry” note wired to refreshPools, while keeping Claim disabled until the amount is known.

pheobeayo · 2026-05-25T13:42:45Z

-// Story shell — renders the widget inside a fixed-width container that mirrors
-// the GoodWalletV2 sidebar / bottom-sheet form factor.
-// ---------------------------------------------------------------------------
+const DEMO_ADDRESS = '0xd8dA6BF26964aF9D7eEd9e03E53415D37aA96045'


Is DEMO_ADDRESS intentionally Vitalik's well-known address? That's fine as a fixture, just worth confirming it's deliberate and that this address doesn't have any unexpected behaviour on Celo or Base in the test environment. If it's just a placeholder, a clearly synthetic address like 0xdeadbeefdeadbeefdeadbeefdeadbeefdeadbeef might be less likely to confuse future contributors.

Good catch. Replaced the well-known address with a clearly synthetic fixture address in 3494404 to avoid confusing future contributors.

pheobeayo · 2026-05-25T13:44:18Z

+  },
+]
+
+const sampleStreamHistory: StreamListItem[] = [


sampleStreamHistory spreads sampleStreams at the top, which is consistent with the current adapter behaviour (both lists come from the same getActiveStreams call). When the adapter is updated to fetch real history separately, this fixture will need updating too. In a proper history model, the two lists should be disjoint, since active streams are ongoing and past streams are terminated. Could we add a comment here noting that the fixture should diverge once the adapter is corrected? Makes the follow-up easier to find.

Added the fixture comment in 3494404, noting that sampleStreamHistory mirrors the current SDK-backed adapter and should diverge once past-stream history is fetched separately.

pheobeayo

Impressive work so far @edehvictor , Kindly check through the comments and fix!

edehvictor added 2 commits May 20, 2026 16:41

fix: finalize streaming widget bounty coverage

716716f

fix: tighten streaming widget claim and layout coverage

a4352bb

github-project-automation Bot added this to GoodBounties May 21, 2026

github-project-automation Bot moved this to Prepare AI Task in GoodBounties May 21, 2026

edehvictor mentioned this pull request May 21, 2026

[GoodBounty] Finalize Streaming Widget PR #36

Open

12 tasks

L03TJ3 linked an issue May 22, 2026 that may be closed by this pull request

[GoodBounty] Finalize Streaming Widget PR #36

Open

12 tasks

L03TJ3 removed this from GoodBounties May 22, 2026

L03TJ3 requested review from a team, L03TJ3 and pheobeayo and removed request for a team and L03TJ3 May 22, 2026 12:23

pheobeayo reviewed May 25, 2026

View reviewed changes

pheobeayo suggested changes May 25, 2026

View reviewed changes

fix: surface streaming pool claimable load failures

3494404

edehvictor requested a review from pheobeayo May 25, 2026 17:01

Conversation

edehvictor commented May 21, 2026

Summary

Changes

Verification

Evidence

Notes

Uh oh!

edehvictor commented May 21, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pheobeayo left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants