fix: Safer check before calling start()#656
Open
tmcw wants to merge 1 commit intoGoogleChromeLabs:mainfrom
Open
fix: Safer check before calling start()#656tmcw wants to merge 1 commit intoGoogleChromeLabs:mainfrom
tmcw wants to merge 1 commit intoGoogleChromeLabs:mainfrom
Conversation
Author
|
Checking in - is this module still maintained, any chance to check out this issue? |
|
I recommend checking out https://github.com/daniel-nagy/transporter
…On Fri, 11 Oct 2024, 19:22 Tom MacWright, ***@***.***> wrote:
Checking in - is this module still maintained, any chance to check out
this issue?
—
Reply to this email directly, view it on GitHub
<#656 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAVSGJ5PKSFJOEOCWF22UVDZ3ACMNAVCNFSM6AAAAABPZKRRIWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBXHAZTKOBUGE>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
This fix is legit, and just in order to get it we are considering to fork. @benjamind @surma any chance to get this in a patch version soon? If the DOM contains an element with id "start" it will break comlink because of this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In both of these cases, the
epvariable is the scope, and in some cases there'll be astart()method available, and we want to call it. I'm not sure exactly why - such a method doesn't show up in GlobalWorkerScope but maybe it's somewhere else.However, there might also just be a variable called
startin your global scope, and it isn't a function, and Comlink will expect it to be callable. This PR compensates for that case by making sure that the value is a function before calling it.