Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 56 additions & 0 deletions secret-manager/createSecretWithCmek.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
// Copyright 2026 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// https://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

'use strict';

async function main(parent, secretId, kmsKeyName) {
// [START secretmanager_create_secret_with_cmek]
/**
* TODO(developer): Uncomment these variables before running the sample.
*/
// const projectId = 'projects/my-project';
// const secretId = 'my-secret-with-cmek';
// const kmsKeyName = 'projects/my-project/locations/global/keyRings/my-keyring/cryptoKeys/my-key';

// Import the Secret Manager library
const {SecretManagerServiceClient} = require('@google-cloud/secret-manager');

// Create the Secret Manager client
const client = new SecretManagerServiceClient();

async function createSecretWithCmek() {
// Create the secret with automatic replication and CMEK
const [secret] = await client.createSecret({
parent: parent,
secretId: secretId,
secret: {
replication: {
automatic: {
customerManagedEncryption: {
kmsKeyName: kmsKeyName,
},
},
},
},
});

console.log(`Created secret ${secret.name} with CMEK key ${kmsKeyName}`);
}

createSecretWithCmek();
Comment on lines +32 to +51
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The main function is async, but the call to createSecretWithCmek() is not awaited. This can lead to the script exiting before the asynchronous operation completes.

Additionally, the createSecretWithCmek function is defined and then immediately called only once. You can simplify the code by removing this inner function and moving its logic directly into the main function. This improves readability and fixes the bug.

    // Create the secret with automatic replication and CMEK
    const [secret] = await client.createSecret({
      parent: parent,
      secretId: secretId,
      secret: {
        replication: {
          automatic: {
            customerManagedEncryption: {
              kmsKeyName: kmsKeyName,
            },
          },
        },
      },
    });

    console.log(`Created secret ${secret.name} with CMEK key ${kmsKeyName}`);

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All samples contains inner function within main which is showing main functionality of the sample. For consistency with other samples this is not required.

// [END secretmanager_create_secret_with_cmek]
}

const args = process.argv.slice(2);
main(...args).catch(console.error);
61 changes: 61 additions & 0 deletions secret-manager/createSecretWithExpiration.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
// Copyright 2026 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// https://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

'use strict';

async function main(parent, secretId) {
// [START secretmanager_create_secret_with_expiration]
/**
* TODO(developer): Uncomment these variables before running the sample.
*/
// const parent = 'projects/my-project';
// const secretId = 'my-secret';

// Import the Secret Manager library
const {SecretManagerServiceClient} = require('@google-cloud/secret-manager');

// Create the Secret Manager client
const client = new SecretManagerServiceClient();

async function createSecretWithExpiration() {
// Calculate expiration time (1 hour from now)
const expireTime = new Date();
expireTime.setHours(expireTime.getHours() + 1);

// Create the secret with automatic replication and expiration time
const [secret] = await client.createSecret({
parent: parent,
secretId: secretId,
secret: {
replication: {
automatic: {},
},
expireTime: {
seconds: Math.floor(expireTime.getTime() / 1000),
nanos: (expireTime.getTime() % 1000) * 1000000,
},
},
});

console.log(
`Created secret ${secret.name} with expiration time ${expireTime.toISOString()}`
);
}

createSecretWithExpiration();
Comment on lines +31 to +56
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The main function is async, but the call to createSecretWithExpiration() is not awaited. This can lead to the script exiting before the asynchronous operation completes.

Additionally, the createSecretWithExpiration function is defined and then immediately called only once. You can simplify the code by removing this inner function and moving its logic directly into the main function. This improves readability and fixes the bug.

    // Calculate expiration time (1 hour from now)
    const expireTime = new Date();
    expireTime.setHours(expireTime.getHours() + 1);

    // Create the secret with automatic replication and expiration time
    const [secret] = await client.createSecret({
      parent: parent,
      secretId: secretId,
      secret: {
        replication: {
          automatic: {},
        },
        expireTime: {
          seconds: Math.floor(expireTime.getTime() / 1000),
          nanos: (expireTime.getTime() % 1000) * 1000000,
        },
      },
    });

    console.log(
      `Created secret ${secret.name} with expiration time ${expireTime.toISOString()}`
    );

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All samples contains inner function within main which is showing main functionality of the sample. For consistency with other samples this is not required.

// [END secretmanager_create_secret_with_expiration]
}

const args = process.argv.slice(2);
main(...args).catch(console.error);
62 changes: 62 additions & 0 deletions secret-manager/createSecretWithUserManagedReplicationPolicy.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
// Copyright 2026 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// https://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

'use strict';

async function main(parent, secretId, locations, ttl) {
// [START secretmanager_create_ummr_secret]
/**
* TODO(developer): Uncomment these variables before running the sample.
*/
// const parent = 'projects/my-project';
// const secretId = 'my-new-secret';
// const locations = ['us-east1', 'europe-west1'];
// const ttl = 7776000; // Optional: 90 days in seconds

// Import the Secret Manager library
const {SecretManagerServiceClient} = require('@google-cloud/secret-manager');

// Create the Secret Manager client
const client = new SecretManagerServiceClient();

async function createUmmrSecret() {
// Create the secret configuration
const secretConfig = {
replication: {
userManaged: {
replicas: locations.map(location => ({location})),
},
},
ttl: {
seconds: ttl,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The createSecret API expects the seconds field for ttl to be a number. The current code passes the ttl string argument directly. Based on the example in the comment ('7776000s') and the test, this will be a string with an 's' suffix, which will cause an error. You should parse the integer value from the ttl argument.

        seconds: parseInt(ttl, 10),

Copy link
Author

@khilan-crest khilan-crest Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done
Updated code to pass int not str

},
};

// Create the secret
const [secret] = await client.createSecret({
parent: parent,
secretId: secretId,
secret: secretConfig,
});

console.log(`Created secret: ${secret.name}`);
}

createUmmrSecret();
Comment on lines +33 to +56
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The main function is async, but the call to createUmmrSecret() is not awaited. This can lead to the script exiting before the asynchronous operation completes.

Additionally, the createUmmrSecret function is defined and then immediately called only once. You can simplify the code by removing this inner function and moving its logic directly into the main function. This improves readability and fixes the bug.

    // Create the secret configuration
    const secretConfig = {
      replication: {
        userManaged: {
          replicas: locations.map(location => ({location})),
        },
      },
      ttl: {
        seconds: ttl,
      },
    };

    // Create the secret
    const [secret] = await client.createSecret({
      parent: parent,
      secretId: secretId,
      secret: secretConfig,
    });

    console.log(`Created secret: ${secret.name}`);

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All samples contains inner function within main which is showing main functionality of the sample. For consistency with other samples this is not required.

// [END secretmanager_create_ummr_secret]
}

const args = process.argv.slice(2);
const locations = args[2] ? args[2].split(',') : [];
main(args[0], args[1], locations, args[3]).catch(console.error);
50 changes: 50 additions & 0 deletions secret-manager/deleteSecretExpiration.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
// Copyright 2026 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// https://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

'use strict';

async function main(name = 'projects/my-project/secrets/my-secret') {
// [START secretmanager_delete_secret_expiration]
/**
* TODO(developer): Uncomment these variables before running the sample.
*/
// const name = 'projects/my-project/secrets/my-secret';

// Import the Secret Manager library
const {SecretManagerServiceClient} = require('@google-cloud/secret-manager');

// Create the Secret Manager client
const client = new SecretManagerServiceClient();

async function deleteSecretExpiration() {
// Update the secret with an empty expireTime field to remove the expiration
const [secret] = await client.updateSecret({
secret: {
name: name,
// No expireTime field specified, which will clear it
},
updateMask: {
paths: ['expire_time'],
},
});

console.log(`Removed expiration from secret ${secret.name}`);
}

await deleteSecretExpiration();
// [END secretmanager_delete_secret_expiration]
}

const args = process.argv.slice(2);
main(...args).catch(console.error);
72 changes: 72 additions & 0 deletions secret-manager/detachTagBinding.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,72 @@
// Copyright 2026 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// https://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

'use strict';

async function main(name, tagValue) {
// [START secretmanager_detach_tag_binding]
/**
* TODO(developer): Uncomment these variables before running the sample.
*/
// const name = 'projects/my-project/secrets/my-secret';
// const tagValue = 'tagValues/123456789012';

// Import the Resource Manager and Secret Manager libraries
const {TagBindingsClient} = require('@google-cloud/resource-manager').v3;

// Create the Resource Manager client
const rmClient = new TagBindingsClient();

// Build the resource name of the parent secret
const parent = `//secretmanager.googleapis.com/${name}`;

async function detachTag() {
// Find the binding name for the given tag value
let bindingName = null;
const iterable = rmClient.listTagBindingsAsync(
{
parent: parent,
pageSize: 50,
},
{autoPaginate: false}
);

for await (const binding of iterable) {
if (binding.tagValue === tagValue) {
bindingName = binding.name;
break;
}
}

if (bindingName === null) {
console.log(`Tag binding for value ${tagValue} not found on ${name}.`);
return;
}

// Delete the tag binding
const [operation] = await rmClient.deleteTagBinding({
name: bindingName,
});

// Wait for the operation to complete
await operation.promise();
console.log(`Detached tag value ${tagValue} from ${name}`);
}

detachTag();
Comment on lines +34 to +67
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The main function is async, but the call to detachTag() is not awaited. This can lead to the script exiting before the asynchronous operation completes.

Additionally, the detachTag function is defined and then immediately called only once. You can simplify the code by removing this inner function and moving its logic directly into the main function. This improves readability and fixes the bug.

    // Find the binding name for the given tag value
    let bindingName = null;
    const iterable = rmClient.listTagBindingsAsync(
      {
        parent: parent,
        pageSize: 50,
      },
      {autoPaginate: false}
    );

    for await (const binding of iterable) {
      if (binding.tagValue === tagValue) {
        bindingName = binding.name;
        break;
      }
    }

    if (bindingName === null) {
      console.log(`Tag binding for value ${tagValue} not found on ${name}.`);
      return;
    }

    // Delete the tag binding
    const [operation] = await rmClient.deleteTagBinding({
      name: bindingName,
    });

    // Wait for the operation to complete
    await operation.promise();
    console.log(`Detached tag value ${tagValue} from ${name}`);

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All samples contains inner function within main which is showing main functionality of the sample. For consistency with other samples this is not required.

// [END secretmanager_detach_tag_binding]
}

const args = process.argv.slice(2);
main(...args).catch(console.error);
47 changes: 47 additions & 0 deletions secret-manager/listSecretVersionsWithFilter.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
// Copyright 2026 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// https://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

'use strict';

async function main(parent = 'projects/my-project/secrets/my-secret') {
// [START secretmanager_list_secret_versions_with_filter]
/**
* TODO(developer): Uncomment these variables before running the sample.
*/
// const parent = 'projects/my-project/secrets/my-secret';
const filterStr = 'state=DISABLED';

// Imports the Secret Manager library
const {SecretManagerServiceClient} = require('@google-cloud/secret-manager');

// Instantiates a client
const client = new SecretManagerServiceClient();

async function listSecretVersionsWithFilter() {
const [versions] = await client.listSecretVersions({
parent: parent,
filter: filterStr,
});

versions.forEach(version => {
console.log(`Found version: ${version.name}`);
});
}

listSecretVersionsWithFilter();
Comment on lines +31 to +42
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The main function is async, but the call to listSecretVersionsWithFilter() is not awaited. This can lead to the script exiting before the asynchronous operation completes.

Additionally, the listSecretVersionsWithFilter function is defined and then immediately called only once. You can simplify the code by removing this inner function and moving its logic directly into the main function. This improves readability and fixes the bug.

    const [versions] = await client.listSecretVersions({
      parent: parent,
      filter: filterStr,
    });

    versions.forEach(version => {
      console.log(`Found version: ${version.name}`);
    });

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All samples contains inner function within main which is showing main functionality of the sample. For consistency with other samples this is not required.

// [END secretmanager_list_secret_versions_with_filter]
}

const args = process.argv.slice(2);
main(...args).catch(console.error);
Loading