Skip to content

chore: add infrastructure-public-image- tag to python-samples-testing-docker #13679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
suztomo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: add infrastructure-public-image- tag to python-samples-testing-docker #13679

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .kokoro/docker/cloudbuild.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,11 @@ steps:
dir: '.kokoro/docker'
- name: gcr.io/cloud-builders/docker
args: ['tag', 'gcr.io/$PROJECT_ID/python-samples-testing-docker', 'gcr.io/$PROJECT_ID/python-samples-testing-docker:$SHORT_SHA']
- name: gcr.io/cloud-builders/docker
args: ['tag', 'gcr.io/$PROJECT_ID/python-samples-testing-docker', 'gcr.io/$PROJECT_ID/python-samples-testing-docker:infrastructure-public-image-$SHORT_SHA']
Comment on lines +23 to +24
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This new step duplicates the image name gcr.io/$PROJECT_ID/python-samples-testing-docker, which is also used in the preceding step and in the images list. This repetition makes the configuration harder to maintain and more prone to errors if the image name ever needs to change.

To improve maintainability, I recommend defining the base image name as a user-defined substitution variable at the top of your cloudbuild.yaml file.

For example:

substitutions:
  _IMAGE_NAME: 'gcr.io/$PROJECT_ID/python-samples-testing-docker'

You can then use ${_IMAGE_NAME} throughout the file, which will make future updates much easier and safer. For example:

...
    - name: gcr.io/cloud-builders/docker
      args: ['tag', '${_IMAGE_NAME}', '${_IMAGE_NAME}:$SHORT_SHA']
    - name: gcr.io/cloud-builders/docker
      args: ['tag', '${_IMAGE_NAME}', '${_IMAGE_NAME}:infrastructure-public-image-$SHORT_SHA']
images:
     - '${_IMAGE_NAME}'
     - '${_IMAGE_NAME}:infrastructure-public-image-$SHORT_SHA'

While this change is outside the scope of a direct code suggestion for this PR, I strongly recommend applying this refactoring for better long-term maintainability.

images:
- 'gcr.io/$PROJECT_ID/python-samples-testing-docker'
- 'gcr.io/$PROJECT_ID/python-samples-testing-docker:infrastructure-public-image-$SHORT_SHA'

options:
logging: CLOUD_LOGGING_ONLY