chore(deps): update mirror.gcr.io/library/ubuntu docker tag to v26#14153
Open
renovate-bot wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Open
chore(deps): update mirror.gcr.io/library/ubuntu docker tag to v26#14153renovate-bot wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
renovate-bot wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Conversation
trusted-contributions-gcf
Bot
added
kokoro:force-run
product-auto-label
Bot
added
the
samples
kokoro-team
removed
the
kokoro:force-run
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the base image in the Dockerfile to Ubuntu 26.04. Feedback highlights that Ubuntu 26.04 is not a released version, which will cause the build to fail, and notes that other hardcoded version references in the file were not updated, leading to an inconsistent environment.
| # We want to use LTS ubuntu from our mirror because dockerhub has a | ||
| # rate limit. | ||
| FROM mirror.gcr.io/library/ubuntu:24.04 | ||
| FROM mirror.gcr.io/library/ubuntu:26.04 |
Contributor
There was a problem hiding this comment.
Upgrading the base image to 26.04 is problematic. First, Ubuntu 26.04 is not a released version, so the build will fail when attempting to pull the image. Second, the Dockerfile contains hardcoded references to older versions (e.g., line 103 uses 20.04 and line 238 mentions 24.04) that are not updated, creating an inconsistent environment.
FROM mirror.gcr.io/library/ubuntu:24.04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
24.04→26.04Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Never, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.