Skip to content

Conversation

@gkatzioura
Copy link
Contributor

This is a PR for #2027

On spring-cloud-gcp-core it provides the functionality to generate api tokens in a reactive way. On the spring-cloud-gcp-storage the GCS apis are called through WebClient once they have received a functional token.

@gkatzioura gkatzioura requested a review from a team as a code owner July 15, 2023 22:04
@gkatzioura gkatzioura changed the title Mono gcs Reactive GCS Jul 15, 2023
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 17 Code Smells

76.4% 76.4% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@meltsufin
Copy link
Member

@gkatzioura A lot of the functionality in this PR seems to not be Spring-specific. All of the auth changes would probably fit better in https://github.com/googleapis/google-auth-library-java. The GCS changes would also better fit under https://github.com/googleapis/java-storage. Would you mind opening issues in those repositories to start the relevant discussions?

@gkatzioura
Copy link
Contributor Author

Hi @meltsufin I can do so.

@gkatzioura gkatzioura marked this pull request as draft July 24, 2023 06:58
@meltsufin meltsufin closed this Sep 20, 2023
@brianmaresca
Copy link

i'm particularly interested in the auth portion of this PR. @gkatzioura did this ever make it to google-auth-library-java (or anywhere else)?

@gkatzioura
Copy link
Contributor Author

Hi @brianmaresca raised this pr
googleapis/google-auth-library-java#1297

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants