Replace deprecated Py_FileSystemDefaultEncoding with PyUnicode_Decode… #938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…FSDefault() Py_FileSystemDefaultEncoding has been deprecated in Python 3.12 for removal, the alternative has been avaliable for years, use it.
Author
|
@GrahamDumpleton Would you mind to check this? |
Owner
|
I can’t do anything about it until January as on a trip and have no laptop with developer tools on it. Best I could do is merge a PR with change to develop branch but I can’t make any new release, so may as well use your own patched copy if it is causing a problem. |
Author
That's totally fine. I can wait until January. I am glad that you responded so fast. Take your time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…FSDefault()
Py_FileSystemDefaultEncoding has been deprecated in Python 3.12 for removal, the alternative has been avaliable for years, use it.