Skip to content

Add db table/row definitions to replace enums for data storage#928

Merged
GregHib merged 40 commits intomainfrom
table-definitions
Mar 27, 2026
Merged

Add db table/row definitions to replace enums for data storage#928
GregHib merged 40 commits intomainfrom
table-definitions

Conversation

@GregHib
Copy link
Copy Markdown
Owner

@GregHib GregHib commented Mar 27, 2026

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 27, 2026

Qodana for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2026

Codecov Report

❌ Patch coverage is 41.20112% with 421 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.99%. Comparing base (e265140) to head (7bdc3bf).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...orld/gregs/voidps/engine/data/definition/Tables.kt 45.85% 72 Missing and 13 partials ⚠️
...gregs/voidps/engine/data/config/TableDefinition.kt 14.54% 44 Missing and 3 partials ⚠️
...regs/voidps/engine/data/definition/ColumnReader.kt 51.47% 30 Missing and 3 partials ⚠️
.../gregs/voidps/engine/data/definition/ColumnType.kt 46.29% 23 Missing and 6 partials ⚠️
...d/gregs/voidps/engine/data/config/RowDefinition.kt 13.33% 26 Missing ⚠️
...ain/kotlin/content/skill/crafting/SpinningWheel.kt 0.00% 25 Missing ⚠️
...ame/src/main/kotlin/content/skill/slayer/Slayer.kt 0.00% 22 Missing ⚠️
.../src/main/kotlin/content/skill/crafting/Weaving.kt 0.00% 19 Missing ⚠️
...s/voidps/engine/data/definition/EnumDefinitions.kt 0.00% 12 Missing ⚠️
game/src/main/kotlin/content/entity/obj/Picking.kt 0.00% 11 Missing ⚠️
... and 29 more
Additional details and impacted files
Files with missing lines Coverage Δ
...tlin/world/gregs/voidps/cache/definition/Params.kt 0.00% <ø> (ø)
...idps/engine/entity/character/player/skill/Skill.kt 93.33% <100.00%> (+0.11%) ⬆️
...tlin/content/area/kandarin/ourania/OuraniaAltar.kt 70.00% <100.00%> (+0.76%) ⬆️
...ent/skill/magic/book/modern/EnchantCrossbowBolt.kt 78.12% <100.00%> (ø)
...kotlin/content/area/kharidian_desert/DesertHeat.kt 40.35% <0.00%> (ø)
...n/content/area/kharidian_desert/al_kharid/Ellis.kt 26.98% <66.66%> (ø)
...rc/main/kotlin/content/skill/crafting/Jewellery.kt 77.77% <80.00%> (ø)
...c/main/kotlin/content/skill/runecrafting/Tiaras.kt 76.00% <0.00%> (ø)
...c/main/kotlin/content/skill/slayer/EnchantedGem.kt 8.92% <0.00%> (+0.73%) ⬆️
...ld/gregs/voidps/cache/definition/data/EnumTypes.kt 0.00% <0.00%> (ø)
... and 33 more

... and 6 files with indirect coverage changes

@@             Coverage Diff              @@
##               main     #928      +/-   ##
============================================
- Coverage     38.02%   37.99%   -0.04%     
- Complexity     7865     7925      +60     
============================================
  Files          1618     1624       +6     
  Lines         64562    64844     +282     
  Branches      16150    16208      +58     
============================================
+ Hits          24552    24638      +86     
- Misses        34530    34706     +176     
- Partials       5480     5500      +20     
Components Coverage Δ
Content 36.00% <44.27%> (-0.07%) ⬇️
Engine 45.59% <38.87%> (-0.24%) ⬇️
Network 60.85% <ø> (-0.04%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@GregHib GregHib merged commit a32ed0d into main Mar 27, 2026
5 checks passed
@GregHib GregHib deleted the table-definitions branch March 27, 2026 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant