Skip to content

Add pollnivneach slayer dungeon & bosses #930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GregHib merged 8 commits into from
Mar 28, 2026
+823 −86

Formatting

93f8344
Select commit
Loading
Failed to load commit list.
Merged

Add pollnivneach slayer dungeon & bosses #930

Formatting
93f8344
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 28, 2026 in 1s

38.01% (+0.01%) compared to a32ed0d

View this Pull Request on Codecov

38.01% (+0.01%) compared to a32ed0d

Details

Codecov Report

❌ Patch coverage is 44.88189% with 70 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.01%. Comparing base (a32ed0d) to head (93f8344).

Files with missing lines Patch % Lines
...desert/pollnivneach/dungeon/PollnivneachDungeon.kt 48.00% 17 Missing and 9 partials ⚠️
.../main/kotlin/content/entity/world/RegionLoading.kt 0.00% 14 Missing ⚠️
...ian_desert/pollnivneach/dungeon/MightiestTuroth.kt 26.66% 10 Missing and 1 partial ⚠️
...esert/pollnivneach/dungeon/MonstrousCaveCrawler.kt 30.00% 7 Missing ⚠️
...d/gregs/voidps/engine/data/config/RowDefinition.kt 0.00% 4 Missing ⚠️
...orld/gregs/voidps/engine/data/definition/Tables.kt 33.33% 2 Missing ⚠️
...regs/voidps/engine/data/definition/ColumnReader.kt 91.66% 1 Missing ⚠️
..._desert/pollnivneach/dungeon/DesertSlayerBosses.kt 88.88% 0 Missing and 1 partial ⚠️
...e/src/main/kotlin/content/entity/death/NPCDeath.kt 75.00% 0 Missing and 1 partial ⚠️
...rc/main/kotlin/content/entity/death/PlayerDeath.kt 75.00% 0 Missing and 1 partial ⚠️
... and 2 more
Additional details and impacted files
Files with missing lines Coverage Δ
...nt/area/misthalin/lumbridge/PlayerDeathSignpost.kt 44.44% <ø> (ø)
...regs/voidps/engine/data/definition/ColumnReader.kt 57.50% <91.66%> (+6.02%) ⬆️
..._desert/pollnivneach/dungeon/DesertSlayerBosses.kt 88.88% <88.88%> (ø)
...e/src/main/kotlin/content/entity/death/NPCDeath.kt 69.29% <75.00%> (-0.07%) ⬇️
...rc/main/kotlin/content/entity/death/PlayerDeath.kt 53.46% <75.00%> (+0.40%) ⬆️
...in/content/entity/player/command/ServerCommands.kt 15.95% <0.00%> (-0.18%) ⬇️
...s/src/main/kotlin/world/gregs/voidps/type/Delta.kt 60.00% <0.00%> (-1.37%) ⬇️
...orld/gregs/voidps/engine/data/definition/Tables.kt 46.25% <33.33%> (+0.39%) ⬆️
...d/gregs/voidps/engine/data/config/RowDefinition.kt 11.76% <0.00%> (-1.57%) ⬇️
...esert/pollnivneach/dungeon/MonstrousCaveCrawler.kt 30.00% <30.00%> (ø)
... and 3 more

... and 4 files with indirect coverage changes

@@             Coverage Diff              @@
##               main     #930      +/-   ##
============================================
+ Coverage     37.99%   38.01%   +0.01%     
- Complexity     7928     7936       +8     
============================================
  Files          1624     1627       +3     
  Lines         64844    64950     +106     
  Branches      16208    16233      +25     
============================================
+ Hits          24640    24692      +52     
- Misses        34705    34744      +39     
- Partials       5499     5514      +15
Components Coverage Δ
Content 36.03% <42.05%> (+0.01%) ⬆️
Engine 45.63% <63.15%> (+0.03%) ⬆️
Network 60.85% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov