Skip to content

Add mort'ton and living rock caverns#934

Merged
GregHib merged 14 commits intomainfrom
slayer-monsters
Mar 30, 2026
Merged

Add mort'ton and living rock caverns#934
GregHib merged 14 commits intomainfrom
slayer-monsters

Conversation

@GregHib
Copy link
Copy Markdown
Owner

@GregHib GregHib commented Mar 30, 2026

  • Add mort myre swamp snail combat
  • Add ghast food rotting
  • Add mort'ton afflicted and loar shades Slayer #503
  • Add swamp decay
  • Add living rock caverns
    • Add living rock creatures Slayer #503
    • Add concentrated deposit mining
    • Fix shoal fishing
    • Add entrance and exit rope anims
  • Add item on bank deposit box depositing
  • Add warning dismiss message
  • Add post-death event

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 30, 2026

Qodana for JVM

7 new problems were found

Inspection name Severity Problems
Unused symbol 🔶 Warning 7

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@GregHib GregHib merged commit 2135c40 into main Mar 30, 2026
3 checks passed
@GregHib GregHib deleted the slayer-monsters branch March 30, 2026 20:17
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 30, 2026

Codecov Report

❌ Patch coverage is 21.85090% with 304 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.69%. Comparing base (26d9ef3) to head (83cb883).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...n_mines/living_rock_caverns/LivingRockCreatures.kt 9.23% 59 Missing ⚠️
...ven_mines/living_rock_caverns/LivingRockCaverns.kt 14.54% 46 Missing and 1 partial ⚠️
...sgarnia/dwarven_mines/living_rock_caverns/Farli.kt 6.12% 46 Missing ⚠️
...n/kotlin/content/entity/player/bank/BankDeposit.kt 24.07% 34 Missing and 7 partials ⚠️
...ame/src/main/kotlin/content/skill/mining/Mining.kt 21.62% 13 Missing and 16 partials ⚠️
...in/content/area/morytania/mort_myre_swamp/Ghast.kt 24.13% 22 Missing ⚠️
...orld/gregs/voidps/engine/entity/character/Death.kt 38.88% 11 Missing ⚠️
...n/kotlin/content/area/morytania/mort_ton/Shades.kt 23.07% 10 Missing ⚠️
...ntent/area/morytania/mort_myre_swamp/SwampDecay.kt 68.96% 9 Missing ⚠️
...otlin/content/area/morytania/mort_ton/Afflicted.kt 18.18% 9 Missing ⚠️
... and 6 more
Additional details and impacted files
Files with missing lines Coverage Δ
...me/src/main/kotlin/content/entity/combat/Combat.kt 71.66% <100.00%> (-0.24%) ⬇️
...main/kotlin/content/entity/player/bank/BankOpen.kt 42.30% <100.00%> (+1.13%) ⬆️
...egs/voidps/network/login/protocol/JagExtensions.kt 84.74% <100.00%> (ø)
...rc/main/kotlin/content/entity/npc/combat/Attack.kt 50.34% <0.00%> (-0.69%) ⬇️
...orld/gregs/voidps/engine/data/definition/Tables.kt 45.67% <0.00%> (-0.58%) ⬇️
...ghold_of_player_safety/StrongholdOfPlayerSafety.kt 8.62% <0.00%> (ø)
...e/src/main/kotlin/content/entity/death/NPCDeath.kt 66.92% <33.33%> (-2.37%) ⬇️
...lin/content/entity/player/dialogue/type/Warning.kt 29.03% <20.00%> (-1.74%) ⬇️
...me/src/main/kotlin/content/skill/mining/Pickaxe.kt 63.63% <20.00%> (-36.37%) ⬇️
...ntent/area/morytania/mort_myre_swamp/SwampDecay.kt 68.96% <68.96%> (ø)
... and 9 more

... and 1 file with indirect coverage changes

@@             Coverage Diff              @@
##               main     #934      +/-   ##
============================================
- Coverage     37.80%   37.69%   -0.11%     
- Complexity     7955     7966      +11     
============================================
  Files          1642     1649       +7     
  Lines         65463    65788     +325     
  Branches      16305    16386      +81     
============================================
+ Hits          24746    24801      +55     
- Misses        35200    35449     +249     
- Partials       5517     5538      +21     
Components Coverage Δ
Content 35.58% <20.92%> (-0.14%) ⬇️
Engine 45.59% <35.00%> (-0.04%) ⬇️
Network 60.85% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant