Allow the spray can to paint a chain of blocks at once #1025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
screret
suggested changes
Mar 29, 2024
Contributor
screret
left a comment
screret
left a comment
There was a problem hiding this comment.
I had some question but went to eat in the middle of making this review and promptly forgot.
src/main/java/com/gregtechceu/gtceu/common/item/ColorSprayBehaviour.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gregtechceu/gtceu/common/item/ColorSprayBehaviour.java
Show resolved
Hide resolved
screret
approved these changes
Mar 29, 2024
Member
|
i aplogise for the necroposting, but i feel like an implementation similar to GregTechCEu/GregTech#2368, which (will probally soon) leverage the PipeNet api to walk a pipenet and dynamically recolour it until an intersection, following turns and stopping at non-connected pipes, and also leveraging the machine side grid for the direction |
Member
|
i would be fine with porting it once ive got it functional and ready-to-merge on 1.12 |
screret
pushed a commit
that referenced
this pull request
Mar 30, 2024
* Allow the spray can to paint a chain of blocks at once * Use MutableBlockPos for chain spray painting
screret
added a commit
that referenced
this pull request
Mar 30, 2024
* Port multi-amp energy hatches not giving overclocks. (#1009) * port 1.12#2139, 1.12#1741 * run data * fix crash * requested change part 1 Co-authored-by: Mikerooni <139889766+mikerooni@users.noreply.github.com> * requested changes part 2 --------- Co-authored-by: Mikerooni <139889766+mikerooni@users.noreply.github.com> * Default predicated buttons to hidden, so buttons don't appear before checking their predicate (#1015) * Fix bucket model (#1008) (#1014) * Fix: processing array accepting multiblock machines (#1013) * fix: Enhance ProcessingArrayMachine no longer use MultiBlock machine controller. * fix: Enhance ProcessingArrayMachine no longer use MultiBlock machine controller. * Optimize access widener and convert to access transformer (#1012) * fix fluid pipes converting an empty fluidstack to an (illegal) null (#1010) * Ordered large distillery outputs (#1021) Defaulted to distillation tower recipes instead of distillery Require 1x output hatches Co-authored-by: sirjoekcb <dev@rj1.org> * Wiremill Circuit Recipes (#1004) * Wiremill Circuit Recipes * Ported the 1.12.2 Wiremill Circuit recipes * Keep wooden form in crafting table after recipe (#923) * fix: always apply OC logic even if amount of OC is 0 so that pyrolyse oven penalties apply. (#1017) * feat: make rubber saplings, leaves compostable (#1018) * fix crash in case of somehow pathing air (#1019) * NO, we DO want to keep the PA deprecated. (#1023) * move to event for data loading so it shows up in datapack list (TURNS OUT THE SERVER DOESN'T CALL THIS WTF) (#1024) * Allow the spray can to paint a chain of blocks at once (#1025) * Allow the spray can to paint a chain of blocks at once * Use MutableBlockPos for chain spray painting * Changed return type of getDurabilityForDisplay from int to float (#1026) * Fixes PA voltage stack overflow on load (#1027) Co-authored-by: sirjoekcb <dev@rj1.org> * add ability to use block/fluid tags in multiblock patterns (#1030) * update, update LDlib, changelog (#1031) * update, update LDlib, changelog * more changelog * Grid UI in multiblock part switcher (#1032) * feat: use a grid UI in the multiblock part switcher * chore: version & changelog * fix errors * don't get resource from mod, return null instead. --------- Co-authored-by: Mikerooni <139889766+mikerooni@users.noreply.github.com> Co-authored-by: ctrlaltmilk <iris@ctrlaltmilk.net> Co-authored-by: Alendill <40451613+Alendill@users.noreply.github.com> Co-authored-by: sirjoekcb <nate@rj1.org> Co-authored-by: sirjoekcb <dev@rj1.org> Co-authored-by: Reclipse <narcisprecup233@gmail.com> Co-authored-by: Maxim <maxim235@tutanota.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Allows the spray can to spray paint a chain of blocks, which makes setting up stuff like lasers easier.
Implementation Details
Just takes the looking direction and moves block by block, coloring them, until the block changes.
getPaintDirectionis based off ofplayer.kjs$getFacing().Outcome
When sneaking while spray painting a chain of blocks will now be colored, though once a different block is reached the coloring will stop.
Additional Information
The max length of the chain can be configured in the tool config.