[MUI2] GUI Module #4389
Open
[MUI2] GUI Module #4389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TarLaboratories
added
type: feature
screret
reviewed
Dec 26, 2025
|
|
||
| private static final List<Player> openedContainers = new ArrayList<>(4); | ||
| private static final Object2ObjectMap<ServerPlayer, List<ModularContainerMenu>> openedInWorldContainers = new Object2ObjectOpenHashMap<>(); | ||
| private static final List<ModularContainerMenu> clientInWorldContainers = new ArrayList<>(); |
Contributor
There was a problem hiding this comment.
Won't this leak old client levels if an in world gui is opened and then the player goes to another dimension?
Contributor
Author
There was a problem hiding this comment.
why would it do that?
screret
reviewed
Dec 26, 2025
src/main/java/com/gregtechceu/gtceu/core/mixins/client/KeyboardHandlerMixin.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds only the GUI module, instead of the whole central monitor UI.
Implementation Details
Also changes the
IMonitorModuleinterface to return MUI instead of LDLib UIs and implements image module UI due to requirement to compile without errors.Outcome
Reviewing #4201 is a bit easier