Skip to content

FOV and Block Speed Toggle Config (1.21-v8.0.0)#4844

Closed
SakuraKitsurugi wants to merge 1 commit into
GregTechCEu:1.21-v8.0.0from
SakuraKitsurugi:feature/fov_and_block_speed_config_1.21
Closed

FOV and Block Speed Toggle Config (1.21-v8.0.0)#4844
SakuraKitsurugi wants to merge 1 commit into
GregTechCEu:1.21-v8.0.0from
SakuraKitsurugi:feature/fov_and_block_speed_config_1.21

Conversation

@SakuraKitsurugi
Copy link
Copy Markdown

@SakuraKitsurugi SakuraKitsurugi commented May 17, 2026

What

Adds 2 configs:

  1. Allows players to disable FOV changes from blocks that modify player speed.
  2. Allows players to disable speed change from blocks that modify player speed.

Implementation Details

  • Added one client and one gameplay config in ConfigHolder.java
  • Added an early return in playerTickEvent(TickEvent.PlayerTickEvent event)
  • Added a config check in getValueWithoutWalkingBoost(AttributeInstance attrib) that sets fov to normal as it forces BLOCK_SPEED_BOOST to be included in the calculations.

How Was This Tested

Additional Information

  • I had to modify getValueWithoutWalkingBoost(AttributeInstance attrib) to add two null checks as it kept crashing on me due to for loops complaining about null objects.
  • I am not that great at naming things so, if there are any issues, do tell me.
  • 1.20 PR: FOV and Block Speed Toggle Config (1.20) #4843

@SakuraKitsurugi SakuraKitsurugi requested a review from a team as a code owner May 17, 2026 19:37
@github-actions github-actions Bot added the 1.21 label May 17, 2026
@SakuraKitsurugi SakuraKitsurugi changed the title FOV and Block Speed Toggle Config (1.21) FOV and Block Speed Toggle Config (1.21-v8.0.0) May 17, 2026
@SakuraKitsurugi
Copy link
Copy Markdown
Author

I probably made a PR to the wrong version, thought 1.21.1-v8 branch was newer 🤔

@SakuraKitsurugi SakuraKitsurugi deleted the feature/fov_and_block_speed_config_1.21 branch May 17, 2026 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant