Rank 1 was left out. Bring it back. #127
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A commit in Oct 13, 2019 changed the original rank == 1 comparison to rank > 1. The code segment applies to both situations so we should make it rank >= 1. This change will remove the bug where a rank 1 array of strings gets read as a single fixed length string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A commit in Oct 13, 2019 changed the original rank == 1 comparison to rank > 1. The code segment applies to both situations so we should make it rank >= 1.
This change will remove the bug where a rank 1 array of strings gets read as a single fixed length string.