Skip to content

Nullreq#444

Open
jreadey wants to merge 4 commits intomasterfrom
nullreq
Open

Nullreq#444
jreadey wants to merge 4 commits intomasterfrom
nullreq

Conversation

@jreadey
Copy link
Member

@jreadey jreadey commented Feb 26, 2026

Updates for forward compatibility with hsds 1.0 storage
Modify handling of default request (no parameters) so a 200 is returned (rsp is a list of top-level domains)


Important

Enhance domain request handling and layout retrieval for forward compatibility with hsds 1.0 storage, including updated tests.

  • Behavior:
    • Modify default request handling in domain_sn.py to return 200 with a list of top-level domains when no parameters are provided.
    • Ignore 'db' key at top level in get_domains() in domain_sn.py.
    • Add include_hrefs parameter to get_domains() to include hrefs in domain JSON.
    • Update GET_Domain in domain_sn.py to handle cases where no domain is passed, returning top-level domains.
    • Log warnings for deprecated 'host' parameter usage in GET_Domain.
  • Functions:
    • Add _getLayout() and getLayoutClass() in dsetUtil.py and chunkUtil.py to retrieve layout information from dataset JSON.
    • Use getLayoutClass() in datanode_lib.py to replace direct access to layout class.
  • Error Handling:
    • Remove error raising for missing layout in chunk_crawl.py and chunkUtil.py.
    • Log and raise HTTP errors in dsetUtil.py when layout information is missing or incorrect.
  • Tests:
    • Update testNullDomain in domain_test.py to expect 200 status and validate domain list.
    • Adjust testGetDomain in domain_test.py to check for updated domain response structure.
    • Modify testGet in dataset_test.py to handle changes in layout retrieval logic.

This description was created by Ellipsis for a5985ec. You can customize this summary. It will automatically update as commits are pushed.

return maxdims


def _getLayout(dset_json):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would eventually be nice to re-organize the utils to avoid having to duplicate helpers like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants