-
Notifications
You must be signed in to change notification settings - Fork 807
[Enhancement] [Bugfix] [Feature] 资源包有关优化与修复 #4980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
需要懂其他语言的人完善 i18n |
在BMC4中测试时发现BMC4会判定所有资源包兼容,与原版表现不符,会导致启用/禁用功能失效,故添加警告
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我在 CF 和 MR 分别下载了好几个资源包,结果都显示「游戏版本元数据缺失」。如果真的要为这个显示警告的话,可能很多人都会迷惑。
可能是我搞错了,我还在弄清楚这一块。
HMCLCore/src/main/java/org/jackhuang/hmcl/resourcepack/ResourcepackFile.java
Outdated
Show resolved
Hide resolved
|
我下载了 Translations for Sodium,放在 1.21.9~1.21.11 的资源包文件夹内,启动器会显示「游戏版本元数据缺失」。1.21.8 和 1.21.1 正常。不知道是不是 bug。 |
Co-authored-by: 3gf8jv4dv <3gf8jv4dv@gmail.com>
Co-authored-by: 3gf8jv4dv <3gf8jv4dv@gmail.com>
确实是,我在修 |
…esourcepack-enhancement
Solved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 43 out of 43 changed files in this pull request and generated 11 comments.
Comments suppressed due to low confidence (3)
HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/UpdatesPage.java:215
- The switch statement at lines 209-215 is missing a default case. While the current RemoteMod.Type enum only has CURSEFORGE and MODRINTH, if new types are added in the future, this code will silently fail to set the source. Consider adding a default case to handle unknown types gracefully or log a warning.
HMCLCore/src/main/java/org/jackhuang/hmcl/mod/LocalModFile.java:164 - This method overrides LocalFile.setOld; it is advisable to add an Override annotation.
public void setOld(boolean old) throws IOException {
HMCLCore/src/main/java/org/jackhuang/hmcl/mod/LocalModFile.java:103
- This method overrides LocalFile.getFile; it is advisable to add an Override annotation.
public Path getFile() {
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
HMCLCore/src/main/java/org/jackhuang/hmcl/mod/ResourcePackManager.java
Outdated
Show resolved
Hide resolved
HMCLCore/src/main/java/org/jackhuang/hmcl/util/StringUtils.java
Outdated
Show resolved
Hide resolved
HMCLCore/src/main/java/org/jackhuang/hmcl/mod/ResourcePackManager.java
Outdated
Show resolved
Hide resolved
HMCLCore/src/main/java/org/jackhuang/hmcl/mod/modinfo/PackMcMeta.java
Outdated
Show resolved
Hide resolved
HMCLCore/src/main/java/org/jackhuang/hmcl/mod/ResourcePackManager.java
Outdated
Show resolved
Hide resolved
HMCLCore/src/main/java/org/jackhuang/hmcl/mod/ResourcePackManager.java
Outdated
Show resolved
Hide resolved
HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/ResourcePackListPage.java
Outdated
Show resolved
Hide resolved
| resourcepack.download.title=资源包下载 - %1s | ||
| resourcepack.manage=资源包管理 | ||
| resourcepack.warning.invalid=资源包元数据无效 | ||
| resourcepack.warning.manipulate=资源包的加载可能会受到模组干扰,导致运行效果异常。\n你确定要启用或禁用此资源包吗? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这句描述看起来非常奇怪。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
改了一下,现在呢?
HMCLCore/src/main/java/org/jackhuang/hmcl/util/versioning/VersionRange.java
Outdated
Show resolved
Hide resolved
HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/ResourcePackListPage.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
现在这个文件不是只代表一个 mod 了吧?我觉得可以改名成 RemoteAddon 之类的东西。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这改动有点大吧...?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我觉得还是不要动了,这个类太重要了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
如果要改的话,不如顺便把包名改成org.jackhuang.hmcl.addon然后底下把pack mod modpack以及将来的shader都分成单独的包
HMCLCore/src/main/java/org/jackhuang/hmcl/mod/ResourcePackFile.java
Outdated
Show resolved
Hide resolved
对于这一点,是否需要在资源包管理页面放个提示框之类的,声明一下? |
用户在尝试启用/禁用资源包的时候会弹提示的,虽然只弹一次但是会给5s阅读时间 |
具体改动
LocalAddonFile和LocalFileManager<T extends LocalAddonFile>,使更新对于模组以外的东西(如资源包和光影包)也能适用,从而实现了资源包更新(不保留旧版本)