feat: 添加数据包下载和数据包详细信息页面 #4991
Draft
feat: 添加数据包下载和数据包详细信息页面 #4991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
|
Contributor
Author
应该是 |
# Conflicts: # HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/WorldListItem.java # HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/WorldManagePage.java
Contributor
|
感觉要和我那个资源包的起冲突 :( |
Contributor
Author
已经很冲突了/(ㄒoㄒ)/~~ 主要是原本这个这个实现写的就很屎山，数据包的安装流程与其它资源不一样（毕竟要安装到具体的世界），我原本打算想办法更深入的重构的（不重构可能没办法实现数据包的下载的一些功能），不过昨天看你的PR那么多修改我基本上决定暂缓开发了，等你的PR合并后再开发。我今天写的新内容基本上只是因为发现前几天选择要安装的世界的实现太屎了才改一改的 |
Contributor
|
@Mine-diamond 你现在的下载对话框文字有问题，和光影下载一样，我开了 #5034 ，仿照改一下 |
Contributor
问题在于我那个上千行的 glavo 短时间内不一定会合啊 :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bandicam.2025-12-19.19-46-56-964.mp4