Skip to content

Fix review issues in 2026-03-09 propositions articles (14 languages)#942

Merged
pethers merged 2 commits intomain-bed0b995399e365cfrom
copilot/sub-pr-934
Mar 9, 2026
Merged

Fix review issues in 2026-03-09 propositions articles (14 languages)#942
pethers merged 2 commits intomain-bed0b995399e365cfrom
copilot/sub-pr-934

Conversation

Copy link
Contributor

Copilot AI commented Mar 9, 2026

Addresses all automated code review feedback on the 14-language government propositions articles: CSP hardening, broken script reference, Schema.org/OG metadata conflict, misleading link text, and accessibility gaps.

Changes

  • CSP hardened (all 14 files): Removed 'unsafe-inline' from script-src and style-src; replaced with a SHA-256 hash for the inline theme-detection script — the only inline script in these files

    <!-- Before -->
    script-src 'self' 'unsafe-inline' https:; style-src 'self' 'unsafe-inline' ...
    <!-- After -->
    script-src 'self' 'sha256-5kywaWmasx2qskEerW3kpgep0X5UZtjznuqQqlCSsG8=' https:; style-src 'self' ...
  • Script reference fixed (all 14 files): ../scripts/back-to-top.ts../js/back-to-top.js (the compiled output that actually exists and can be executed by browsers)

  • Schema.org image dimensions corrected (all 14 files): og-image-news.webp JSON-LD dimensions were 512×512, conflicting with OG metadata; corrected to 1200×630. Publisher logo stays at 512×512.

  • Proposition link text normalized (all 14 files): Link labels used internal document IDs (Prop. 2025/26: HD03134) instead of the standard proposition number format used everywhere else in the article body (Prop. 2025/26:134)

  • Skip-link localization (13 non-English files): "Skip to main content" translated to each document's language (e.g. 跳至主要内容 for zh, الانتقال إلى المحتوى الرئيسي for ar)

  • Dutch file lang="en" annotations (nl.html): English-language paragraphs throughout the Dutch article (context-box, deep-analysis, all "Why It Matters" / "Published:" entries) now carry lang="en" so screen readers and search engines do not mispronounce or mis-index them


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

…p-links, lang attrs

Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>
Copilot AI changed the title [WIP] Add government propositions articles for 2026-03-09 Fix review issues in 2026-03-09 propositions articles (14 languages) Mar 9, 2026
@pethers pethers marked this pull request as ready for review March 9, 2026 11:43
@pethers pethers merged commit 57da9b0 into main-bed0b995399e365c Mar 9, 2026
@pethers pethers deleted the copilot/sub-pr-934 branch March 9, 2026 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants