React1 week1/parisa#42
React1 week1/parisa#42SeyedehParisaMousaviamiri wants to merge 3 commits intoHackYourFuture-CPH:mainfrom
Conversation
There was a problem hiding this comment.
Hey 🙂
I noticed you've added some new images. When adding images in a Next.js project, it's best to place them in the /public folder.
However, the task specifically asked you to use the existing images already available in that folder.
To access them, you can simply use the path: /crew/$filename.
| <h3>{member.name}</h3> | ||
| <p>{member.role}</p> | ||
| </div> | ||
| ))} |
There was a problem hiding this comment.
Good job using the .map array methods here!
| @@ -0,0 +1,25 @@ | |||
| const OurCrew = () => { | |||
There was a problem hiding this comment.
Be cautious!
You're currently not exporting anything here, so when you try to import the component elsewhere, the app will crash.
| @@ -0,0 +1,25 @@ | |||
| const OurCrew = () => { | |||
| const crewMembers = [ | |||
| { name: "Alex Johnson", role: "Captain", image: "react-1-hw/app/about_us/Boulder_Worldcup_Vienna_28-05-2010_quali-w100_Alex_Johnson.jpg" }, | |||
There was a problem hiding this comment.
These are absolute file paths from your local machine, which won't work in a deployed web app. Try to move the images to the public folder to resolve this :)
| @@ -0,0 +1,24 @@ | |||
| const OurPartners = () => { | |||
There was a problem hiding this comment.
Attention!
You are not exporting anything here, when you'll try to import it the app will crash :)
| @@ -0,0 +1,24 @@ | |||
| const OurPartners = () => { | |||
| const partners = [ | |||
| { name: "TechCorp", logo: "/partners/techcorp.png" }, | |||
There was a problem hiding this comment.
Are you sure this path exists? I cannot find the "partner" folder inside the public folder
| @@ -0,0 +1,20 @@ | |||
| const OurValues = () => { | |||
There was a problem hiding this comment.
Even here you're encoutering the same export problem!
|
|
||
| {/* TASK - React 1 week 1 */} | ||
| {/* Add a new list item for LINKEDIN */} | ||
| <li> |
There was a problem hiding this comment.
This
- element. Consider moving it inside the ul after the last item to make it look cleaner!
2 participants
No description provided.