Brussels | ITP-2025-1 | Daniela Fajardo | Week 11 | Book library#66
Brussels | ITP-2025-1 | Daniela Fajardo | Week 11 | Book library#66ldfajardo10-tech wants to merge 5 commits intoHackYourFutureBelgium:mainfrom
Conversation
EL1VAS
left a comment
There was a problem hiding this comment.
Helooo! Some changes in Book library index.html:
in line 35 type="title" should be type="text" as title is not a valid type. Same in line 43.
At line 67 value="Submit" is not necassery as you define it as Submit at line 69 (but that's minor).
Changes on script.js of Book library:
Line 10: nice catch correcting Robinson from Robison, no one else that I checked saw that one :)
Line 29-33 Nice clearing the form by submit!
Line 39 after you can add the author conditions so user is obliged to add name, pages AND author of the book: author.value == null || author.value == "".
I see you have the prep files there too, I won't be reviewing those.
|
Thank you for your review @EL1VAS. Make sure to implement the changes necessary @ldfajardo10-tech, good work! |
Learners, PR Template
Self checklist
Some bugs fixed and a new feature added to clear the form once is submited.