Brussels | ITP-2026-1 | Benjamin | Sprint 3 | Quotegenerator | Week 9#124
Open
nuttyproducer wants to merge 2 commits intoHackYourFutureBelgium:mainfrom
Open
Brussels | ITP-2026-1 | Benjamin | Sprint 3 | Quotegenerator | Week 9#124nuttyproducer wants to merge 2 commits intoHackYourFutureBelgium:mainfrom
nuttyproducer wants to merge 2 commits intoHackYourFutureBelgium:mainfrom
Conversation
The quote generator code was working, but the test was failing because the installed version of @testing-library/user-event handles clicks asynchronously. I updated the test to use await so it matches the dependency behavior. I used AI to help investigate the issue and understand why the test was failing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
I finished the quote generator exercise.
I updated the UI and styling of the quote generator and added the interaction logic so that a new quote appears when the button is clicked.
Questions
I used AI to help me understand why the test was failing with
userEvent.click(). Is this OK for future exercises, too if I still understand and explain the solution myself?Included the corrected quotes.test file inside this pull request for reference.