Brussels| 25-ITP-May | Basel Adoum | Sprint 1 | #19
Conversation
BaselAdoum
changed the title
MustafaBora
left a comment
MustafaBora
left a comment
There was a problem hiding this comment.
Well done but try not sending the unnecesary changes to repo next time
MustafaBora
left a comment
MustafaBora
left a comment
There was a problem hiding this comment.
Can you correct the PR by fixing the code according to my comments. And also can you send the related Sprint Sprint 1 please?
Sprint-1/2-mandatory-errors/4.js
Outdated
| @@ -1,2 +1,2 @@ | |||
| const 12HourClockTime = "20:53"; | |||
| const 12HourClockTime = "20:53"; | |||
There was a problem hiding this comment.
Thank you Mustafa
i fixed the code according to your comment. I also checked the commits in github. all in order.
| // const percentageChange = (priceDifference / carPrice) * 100; | ||
|
|
||
| // e) Describe what the expression Number(carPrice.replaceAll(",","")) is doing - what is the purpose of this expression? | ||
| //It removes commas from the string numbers "10,000" and "8,543" to get "10000" and "8543" |
There was a problem hiding this comment.
And also changes the Strings to numbers
| // 1. const penceString = "399p": initialises a string variable with the value "399p" | ||
| // const penceStringWithoutTrailingP deletes the p at the end of the string and gives a new string. | ||
| //paddedPenceNumberString takes that new string and makes sure it is at leas 3 digits (i ncase needed fill the gap with 0 from the left) | ||
| // pounds is a variable that take the first index and declare it as pound. |
There was a problem hiding this comment.
//takes all digits except the last two.
//it’s taking the last two digits, padding is basically unnecessary here because you already padded to 3 digits earlier.
MustafaBora
left a comment
MustafaBora
left a comment
There was a problem hiding this comment.
Unanswered question Sprint1/4-stretch-explore
| Let's try an example. | ||
|
|
||
| In the Chrome console, | ||
| invoke the function `alert` with an input string of `"Hello world!"`; |
MustafaBora
left a comment
MustafaBora
left a comment
There was a problem hiding this comment.
Sprint-1/4-stretch-explore/ folder also needs to be solved please
….)with all the properties this object has
2 participants
Learners, PR Template
Self checklist
Changelist
line 3 is reassigning the value of line one. = is not equal sign but a variable creating operator.
The idea is count is the original count 0 and adding to it 1. So the count is reassigned to 1.