Brussels | ITP-2026-1 | Nikita Sharma | Sprint-3 | Coursework/Sprint-3 implement & rewrite tests#73
Open
nikki08-09 wants to merge 6 commits intoHackYourFutureBelgium:mainfrom
Open
Conversation
noahg9
reviewed
May 4, 2026
| return false; | ||
| } else if (numerator < 0 && Math.abs(numerator) < denominator) { | ||
| return true; | ||
| } |
There was a problem hiding this comment.
Your implementation doesn't work for negative fractions and your tests don't cover it. Try to find a solution
Author
|
Hello
I made the changes. Please have a look on it and closed my PR.
Thank you
Nikita.
…On Mon, 4 May 2026, 9:15 am Noah, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In
Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js
<#73 (comment)>
:
> @@ -10,6 +10,10 @@
function isProperFraction(numerator, denominator) {
if (numerator < denominator) {
return true;
+ } else if (numerator >= denominator) {
+ return false;
+ } else if (numerator < 0 && Math.abs(numerator) < denominator) {
+ return true;
}
Your implementation doesn't work for negative fractions and your tests
don't cover it. Try to find a solution
—
Reply to this email directly, view it on GitHub
<#73 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BXYBQH4MQWLGOQHJDYTII3L4ZA7RBAVCNFSM6AAAAACXIKFJRWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHM2DEMJYGAZDMNBXGY>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
<HackYourFutureBelgium/Module-Structuring-and-Testing-Data/pull/73/review/4218026476
@github.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist