This repository was archived by the owner on Jun 11, 2023. It is now read-only.
Open
Conversation
cf550ad to
6e63611
Compare
7efbfc2 to
2ddbcef
Compare
2ddbcef to
e2ab25b
Compare
a1404e3 to
4514f6a
Compare
4514f6a to
2a215ea
Compare
|
Ebert has finished reviewing this Pull Request and has found:
You can see more details about this review at https://ebertapp.io/github/HackerExperience/Helix/pulls/410. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will be a rather large PR meant to enhance (but mostly rewrite) the Log service.
The biggest improvement is that now logs are structured data with pre-defined types, as opposed to the old Log system who was simply a string, void of any context.
So we changed from:
String:
"localhost downloaded file Cracker.crc (1.0) from 1.2.3.4"to
Struct:
{type: :download_gateway, file_name: "Cracker.crc (1.0)", ip: "1.2.3.4", network_id: "::"}To the end user this change is transparent (the struct will be "translated" to the string above anyways). But this allows for:
Incidental
ex_machinadependency 🎉tgt_log_idonProcess.tstructset_relay/3macro forHelix.FactorSIGRETARGET, i.e. support for recursive process type (Support different types of processes lifecycles on TOP #324)custompre-hook atProcess.ExecutableThis change is