Upgrade sqlite to 3.51.2 #1132
Open
Upgrade sqlite to 3.51.2 #1132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singpolyma
force-pushed
the
update-sqlite
branch
from
3a30bc7 to
03721cd
Compare
To prevent blocking GC in other threads.
Open
hughsando
reviewed
Jan 13, 2026
src/hx/libs/sqlite/Sqlite.cpp
Outdated
| sqlite3 *sqlDb = 0; | ||
| if( (err = sqlite3_open(filename.utf8_str(),&sqlDb)) != SQLITE_OK ) | ||
| __hxcpp_enter_gc_free_zone(); | ||
| int err = sqlite3_open(filename.utf8_str(),&sqlDb); |
Member
There was a problem hiding this comment.
The conversion to utf8 here may generate a GC event, so this should happen outside the gc_free_zone and be stored in a local variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also need to run sqlite blocking IO inside a gc free zone.