Did Error handling and some other minor changes#28
Closed
priya-gitTest wants to merge 2 commits intoHealth-RI:mainfrom
Closed
Did Error handling and some other minor changes#28priya-gitTest wants to merge 2 commits intoHealth-RI:mainfrom
priya-gitTest wants to merge 2 commits intoHealth-RI:mainfrom
Conversation
…set. The Classes used might not be the ones you want to use, but this works so its fine for now. Kindly change the classes , if needed else I might make a new release later this week,
…dling Did Error Handing and Fixed issues related to adding Catalog and Data…
|
Contributor
|
Thank you priya-gitTest for this PR. As mentioned in PR #48, the notebooks have been rewritten to use fairclient, which contains better handling of the connections. A better user experience, including better error handling, will be put on the roadmap. Since the codebase has changed since the creation of this PR, I will close this for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code runs correctly to add the catalog and dataset.
It might not be using the classes you created but works for now.