override for type in migratable_vc_domains #432
Conversation
|
Can you please update the test cases as well? to match the resource file changes you have made. |
| "credentials": { | ||
| "userName": "Administrator", | ||
| "password": "" | ||
| "password": "GSE#admin1" |
| config['enclosure_username'], | ||
| config['enclosure_password'], | ||
| config['vcmUsername'], config['vcmPassword'], | ||
| type = 'MigratableVcDomainV300', |
| @staticmethod | ||
| def make_migration_information(oaIpAddress, oaUsername, oaPassword, vcmUsername, vcmPassword, | ||
| iloLicenseType='OneView', enclosureGroupUri=None): | ||
| type = 'migratable-vc-domains', iloLicenseType='OneView', enclosureGroupUri=None): |
There was a problem hiding this comment.
Adding type filed here is not a good idea.
Add DEFAULT_VALUES class variable to support type field for different versions.
Refer this file, https://github.com/HewlettPackard/python-hpOneView/blob/master/hpOneView/resources/networking/fc_networks.py
sijeesh
left a comment
sijeesh
left a comment
There was a problem hiding this comment.
Looks good to me, need to make some changes in MigratableVcDoamins class
Update MigratableVcDoamins class - inherit from Resource base class and remove common methods as delete create, get, etc. from MigratableVcDomains class
Use FCNetwork module for reference - https://github.com/HewlettPackard/python-hpOneView/blob/master/hpOneView/resources/networking/fc_networks.py
3 participants
Description
[Describe what this change achieves]
The code has been changed in :
python-hpOneView\hpOneView\resources\servers\migratable_vc_domains.py
The change is in the function "make_migration_information" wherein a parameter has been
added with the default value for 'type' as 'migratable-vc-domains'.
python-hpOneView\examples\migratable_vc_domains.py
The call to the above function will have a parameter passed as "type = 'MigratableVcDomainV300' "
Issues Resolved
[List any issues this PR will resolve. e.g., Fixes #1]
Issue #431
Check List
$ tox).