Skip to content

Use clang-tidy settings from AMReX#1325

Open
AlexanderSinn wants to merge 40 commits intoHi-PACE:developmentfrom
AlexanderSinn:test_with_clang_tidy_settings_from_AMReX
Open

Use clang-tidy settings from AMReX#1325
AlexanderSinn wants to merge 40 commits intoHi-PACE:developmentfrom
AlexanderSinn:test_with_clang_tidy_settings_from_AMReX

Conversation

@AlexanderSinn
Copy link
Copy Markdown
Member

@AlexanderSinn AlexanderSinn commented Dec 9, 2025

This PR extends the clang-tidy checks to most of the ones that AMReX uses and fixes all the issues found by those checks.

  • Small enough (< few 100s of lines), otherwise it should probably be split into smaller PRs
  • Tested (describe the tests in the PR description)
  • Runs on GPU (basic: the code compiles and run well with the new module)
  • Contains an automated test (checksum and/or comparison with theory)
  • Documented: all elements (classes and their members, functions, namespaces, etc.) are documented
  • Constified (All that can be const is const)
  • Code is clean (no unwanted comments, )
  • Style and code conventions are respected at the bottom of https://github.com/Hi-PACE/hipace
  • Proper label and GitHub project, if applicable

@AlexanderSinn AlexanderSinn changed the title test with clang-tidy settings from AMReX Use clang-tidy settings from AMReX Apr 22, 2026
Copy link
Copy Markdown
Contributor

@lucafedeli88 lucafedeli88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I forgot about this PR. Sorry if I've reviewed it only now.

Comment thread src/diagnostics/Diagnostic.cpp
Comment thread src/diagnostics/Diagnostic.cpp
Comment thread src/diagnostics/OpenPMDWriter.cpp
Comment thread src/fields/Fields.cpp
Comment thread src/fields/Fields.H
Comment thread src/particles/plasma/PlasmaParticleContainer.cpp
Comment thread src/particles/plasma/PlasmaParticleContainer.cpp
Comment thread src/particles/plasma/PlasmaParticleContainerInit.cpp
Comment thread src/particles/plasma/PlasmaParticleContainerInit.cpp
Comment thread src/utils/MultiBuffer.H
@AlexanderSinn AlexanderSinn added the CI Continuous integration, checksum and analysis tests, GitHub Actions, etc. label Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Continuous integration, checksum and analysis tests, GitHub Actions, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants