add stealing to post match and change other stuff#82
Conversation
|
@leok18 could you get checks to pass? |
lib/collection/StealerType.ts
Outdated
| stealerType: StealerType.toAlliance, | ||
| localizedDescription: "To Alliance", | ||
| localizedLongDescription: | ||
| "The robot steals fuel and brings it to the alliance zone.", |
There was a problem hiding this comment.
Can we change the language to be more inclusive of pushing fuel? Right now it sounds like you have to intake it.
And can we also ask about pushing vs shooting here?
lib/collection/RobotRole.ts
Outdated
| role: RobotRole.Stealing, | ||
| localizedDescription: "Stealing", | ||
| localizedLongDescription: | ||
| "The robot focuses on stealing fuel from the opposing alliance.", |
There was a problem hiding this comment.
I don't think we want to say "focuses" because we're looking for all roles played, not just the one played for the majority of the match.
lib/collection/reportStateStore.ts
Outdated
| scoresWhileMoving: | ||
| reportState.scoresWhileMoving === ScoresWhileMoving.Yes, | ||
| endgameClimb: endgameClimbToString(reportState.climbResult), | ||
| stealerTypes: reportState.stealerType.map() |
There was a problem hiding this comment.
I'm noticing some inconsistent language with stealingType vs stealerType vs stealerTypes. Completely fine, we just need to make sure Jack is clear on which to use for what situation.
| case RobotRole.Immobile: | ||
| default: | ||
| return "IMMOBILE"; | ||
| case RobotRole.Stealing: | ||
| return "STEALING"; |
There was a problem hiding this comment.
This switch statement looks really wrong
| switch (feederType) { | ||
| case FeederType.Continuous: | ||
| return "CONTINUOUS"; | ||
| case FeederType.StopToShoot: | ||
| return "STOP_TO_SHOOT"; | ||
| case FeederType.Dump: | ||
| return "DUMP"; | ||
| case FeederType.Push: | ||
| return "PUSH"; | ||
| default: | ||
| return "PUSH"; | ||
| } |
There was a problem hiding this comment.
This will return "PUSH" if you input FeederType.Dump
2 participants
No description provided.