Open
Conversation
MangoSwirl
reviewed
Mar 25, 2026
Member
MangoSwirl
left a comment
MangoSwirl
left a comment
There was a problem hiding this comment.
Looks good! Just trying to think about how this fits into the larger implementation. Remind me, did we decide against adding back the "Stealer" role?
| final EndgameClimbResult climbResult; | ||
| final num climbStartTime; | ||
| final List<FeederType> feederType; | ||
| final List<StealerType> stealerType; |
Member
There was a problem hiding this comment.
Are you showing this value anywhere in the UI?
| final num scoringRate; | ||
| final num feedingRate; | ||
| final num defenseEffectiveness; | ||
| final num? defenseEffectiveness; |
Member
There was a problem hiding this comment.
If defenseEffectiveness is null then will it properly hide the box in the UI? or will it say "null/5"?
Member
Oh, I see you did add stealer on collection. Add it here as well? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.