Conversation
Add mismatch_apertures to the public export list. It was already defined at module scope as the aperture-wise counterpart to mismatch, but callers needed qualified access (RegisterMismatchCommon.mismatch_apertures) to use it. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Breaking changes (accepted at patch per package policy): - register_translate: positional `thresh` removed; use `thresh=…` keyword - assertsamesize renamed to checksamesize (@deprecate shim kept) - mismatch0 renamed to mismatch_zeroshift (@deprecate shim kept) - set_FFTPROD removed; use const FFTPROD = Ref([2,3]) directly Non-breaking additions: - Export mismatch_apertures - mismatch/mismatch_apertures forward kwargs… to downstream protocol - Add non-mutating correctbias and truncatenoise companions - Export FFTPROD (Ref-based mutable config) Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #23 +/- ##
==========================================
+ Coverage 87.44% 90.49% +3.04%
==========================================
Files 1 1
Lines 239 242 +3
==========================================
+ Hits 209 219 +10
+ Misses 30 23 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Breaking (accepted at patch per package policy — controlled downstream):
register_translate: positionalthreshremoved; usethresh=…keywordassertsamesize→checksamesize(@deprecateshim kept for one-release migration)mismatch0→mismatch_zeroshift(@deprecateshim kept)set_FFTPROD(v)removed; mutate viaRegisterMismatchCommon.FFTPROD[] = vdirectly (const FFTPROD = Ref([2,3])is now exported)Non-breaking additions:
mismatch_aperturesmismatch/mismatch_aperturesforwardkwargs…to downstream protocol (no longer hard-codingnormalization=:intensity)correctbiasandtruncatenoisecompanions (follow Basef/f!convention)Test plan
🤖 Generated with Claude Code