Conversation
Covers the previously-untested protocol entry points:
- mismatch(non-AbstractFloat arrays, …) → promotes to Float32 (line 80)
- mismatch_apertures(AbstractFloat arrays, …) → typed dispatch (line 82)
- mismatch_apertures(non-AbstractFloat arrays, …) → promotes to Float32 (line 83)
- mismatch_apertures(::Type{T}, fixed, moving, gridsize, maxshift) → gridsize form (lines 85-89)
Coverage: 90.5% → 93.8%. Remaining uncovered region is the internal
unsafe-view utilities (extraunsafe_view / unsafe_reindex), which are only
exercised by downstream FFT implementations.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #24 +/- ##
==========================================
+ Coverage 90.49% 93.80% +3.30%
==========================================
Files 1 1
Lines 242 242
==========================================
+ Hits 219 227 +8
+ Misses 23 15 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mismatch(non-AbstractFloat arrays, …)→ promotes to Float32 (line 80)mismatch_apertures(AbstractFloat arrays, …)→ typed dispatch (line 82)mismatch_apertures(non-AbstractFloat arrays, …)→ promotes to Float32 (line 83)mismatch_apertures(::Type{T}, fixed, moving, gridsize, maxshift)→ gridsize form (lines 85–89)register_translatetestsetRemaining uncovered region
Lines 610–635:
extraunsafe_view,_tail,get_index_wo_boundcheck,unsafe_reindex— internal unsafe-view helpers only exercised by downstream FFT implementations (RegisterMismatch,RegisterMismatchCuda). An existing# TODO: redesigncomment marks them for future attention.Test plan
🤖 Generated with Claude Code