Skip to content

Add tests for mismatch/mismatch_apertures promoting dispatch (90.5% → 93.8%)#24

Merged
kdw503 merged 1 commit into
masterfrom
dwk/mng
May 18, 2026
Merged

Add tests for mismatch/mismatch_apertures promoting dispatch (90.5% → 93.8%)#24
kdw503 merged 1 commit into
masterfrom
dwk/mng

Conversation

@kdw503
Copy link
Copy Markdown
Member

@kdw503 kdw503 commented May 18, 2026

Summary

  • Adds a new testset covering the previously-untested protocol entry points:
    • mismatch(non-AbstractFloat arrays, …) → promotes to Float32 (line 80)
    • mismatch_apertures(AbstractFloat arrays, …) → typed dispatch (line 82)
    • mismatch_apertures(non-AbstractFloat arrays, …) → promotes to Float32 (line 83)
    • mismatch_apertures(::Type{T}, fixed, moving, gridsize, maxshift) → gridsize form (lines 85–89)
  • Uses the same local-stub pattern already established in the register_translate testset
  • Coverage: 90.5% → 93.8%

Remaining uncovered region

Lines 610–635: extraunsafe_view, _tail, get_index_wo_boundcheck, unsafe_reindex — internal unsafe-view helpers only exercised by downstream FFT implementations (RegisterMismatch, RegisterMismatchCuda). An existing # TODO: redesign comment marks them for future attention.

Test plan

  • 327/327 tests passing

🤖 Generated with Claude Code

Covers the previously-untested protocol entry points:
- mismatch(non-AbstractFloat arrays, …) → promotes to Float32 (line 80)
- mismatch_apertures(AbstractFloat arrays, …) → typed dispatch (line 82)
- mismatch_apertures(non-AbstractFloat arrays, …) → promotes to Float32 (line 83)
- mismatch_apertures(::Type{T}, fixed, moving, gridsize, maxshift) → gridsize form (lines 85-89)

Coverage: 90.5% → 93.8%. Remaining uncovered region is the internal
unsafe-view utilities (extraunsafe_view / unsafe_reindex), which are only
exercised by downstream FFT implementations.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.80%. Comparing base (6e8629b) to head (ec85d24).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
+ Coverage   90.49%   93.80%   +3.30%     
==========================================
  Files           1        1              
  Lines         242      242              
==========================================
+ Hits          219      227       +8     
+ Misses         23       15       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kdw503 kdw503 merged commit 06cfe2c into master May 18, 2026
4 checks passed
@kdw503 kdw503 deleted the dwk/mng branch May 18, 2026 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant