Skip to content

Synchronize ruby-version to ruby-macho #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
p-linnane wants to merge 1 commit into from
Closed

Synchronize ruby-version to ruby-macho #396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions .github/actions/sync/shared-config.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,9 +113,6 @@ def git(*args)
end
dependabot_config = dependabot_config_yaml.to_yaml

custom_ruby_version_repos = %w[
ruby-macho
].freeze
custom_rubocop_repos = %w[
ci-orchestrator-private
ruby-macho
Expand Down Expand Up @@ -207,8 +204,6 @@ def git(*args)
"#{contents}\n",
)
when ruby_version
next if custom_ruby_version_repos.include?(repository_name)

target_path = target_directory_path/"Library/Homebrew/#{ruby_version}" if repository_name == "brew"

if target_path.exist?
Expand Down Expand Up @@ -260,9 +255,7 @@ def git(*args)
# Update Gemfile.lock if it exists, based on the Ruby version.
#
# We don't need to sync Gemfiles in Homebrew/brew because they are the source of truth.
# We don't have Homebrew exclude? method here.
# rubocop:disable Homebrew/NegateInclude
if !custom_ruby_version_repos.include?(repository_name) && repository_name != "brew"
if repository_name != "brew"
target_gemfile_locks.each do |target_gemfile_lock|
target_directory_path = target_gemfile_lock.dirname
Dir.chdir target_directory_path do
Expand All @@ -278,7 +271,6 @@ def git(*args)
end
end
end
# rubocop:enable Homebrew/NegateInclude

out, err, status = Open3.capture3("git", "-C", target_directory, "status", "--porcelain", "--ignore-submodules=dirty")
raise err unless status.success?
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/sync-shared-config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,12 +45,12 @@ jobs:
Homebrew/discussions
Homebrew/formulae.brew.sh
Homebrew/glibc-bootstrap
Homebrew/homebrew-brew-vulns
Homebrew/homebrew-cask
Homebrew/homebrew-core
Homebrew/install
Homebrew/private
Homebrew/ruby-macho
Homebrew/homebrew-brew-vulns
)
if [[ "${SKIP_PRIVATE}" == true ]]; then
read -r -a repositories <<< "${repositories[@]//*private}"
Expand Down
Loading