Skip to content

fix: validate and bound pagination limit and offset in API routes#33

Closed
Shreyassp002 wants to merge 1 commit into
mainfrom
fix/api-pagination-nan-13643944272714269455
Closed

fix: validate and bound pagination limit and offset in API routes#33
Shreyassp002 wants to merge 1 commit into
mainfrom
fix/api-pagination-nan-13643944272714269455

Conversation

@Shreyassp002
Copy link
Copy Markdown
Contributor

Category: Bug
Priority: P1
What: Added isNaN and negative value checks to limit and offset parsing across four transaction and payment-link API routes. It ensures that variables use safe defaults and limits.
Why: If a client sends a non-numeric string (e.g. ?limit=abc), parseInt returns NaN, and Math.min(NaN, 100) evaluates to NaN. Passing NaN into Supabase database queries causes errors or undefined behaviors.
Impact: Prevents database query failures due to malformed pagination parameters.
Verification: Ran npm run lint and npm run build which passed successfully. Verified that package.json changes were omitted as per project boundaries.


PR created automatically by Jules for task 13643944272714269455 started by @Shreyassp002

Added `isNaN` and negative value checks to `limit` and `offset` parsing across API routes (`v1/payment-links`, `v1/transactions`, `transactions`, `transactions/history`) to prevent `NaN` or invalid values from being passed to Supabase `.range()` queries, avoiding database errors and improving API reliability.

Co-authored-by: Shreyassp002 <96625037+Shreyassp002@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 1, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
flash-protocol Error Error May 1, 2026 6:10am

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 1, 2026

⚡ Flash Review

Metric Value
Files Reviewed 4
Risk Level 🟢 Low
Issues Found None

✅ This PR looks clean. No security issues, bugs, or significant improvements found.


⚡ Powered by Flash Review

@Shreyassp002
Copy link
Copy Markdown
Contributor Author

Closing as duplicate of #31 which has been merged.

@Shreyassp002 Shreyassp002 deleted the fix/api-pagination-nan-13643944272714269455 branch May 7, 2026 07:01
@google-labs-jules
Copy link
Copy Markdown
Contributor

Closing as duplicate of #31 which has been merged.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant