fix: validate and bound pagination limit and offset in API routes#33
fix: validate and bound pagination limit and offset in API routes#33Shreyassp002 wants to merge 1 commit into
Conversation
Added `isNaN` and negative value checks to `limit` and `offset` parsing across API routes (`v1/payment-links`, `v1/transactions`, `transactions`, `transactions/history`) to prevent `NaN` or invalid values from being passed to Supabase `.range()` queries, avoiding database errors and improving API reliability. Co-authored-by: Shreyassp002 <96625037+Shreyassp002@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
⚡ Flash Review
✅ This PR looks clean. No security issues, bugs, or significant improvements found. ⚡ Powered by Flash Review |
|
Closing as duplicate of #31 which has been merged. |
Understood. Acknowledging that this work is now obsolete and stopping work on this task. |
Category: Bug
Priority: P1
What: Added
isNaNand negative value checks tolimitandoffsetparsing across four transaction and payment-link API routes. It ensures that variables use safe defaults and limits.Why: If a client sends a non-numeric string (e.g.
?limit=abc),parseIntreturnsNaN, andMath.min(NaN, 100)evaluates toNaN. PassingNaNinto Supabase database queries causes errors or undefined behaviors.Impact: Prevents database query failures due to malformed pagination parameters.
Verification: Ran
npm run lintandnpm run buildwhich passed successfully. Verified thatpackage.jsonchanges were omitted as per project boundaries.PR created automatically by Jules for task 13643944272714269455 started by @Shreyassp002