Migrate source copybook fix #170
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The Auto Fix was adding
/copystatements for includes that existed in nested include files, not just the main source file.Root cause
When parsing RPGLE files with
withIncludes: true, the parser recursively processes all includes and returns them all incache.includes. The code was processing ALL includes without checking which file they came from.Here's an example of what this looked like in one of my converted sources with the before and after image.
Notice lines 17, 22 and 23 in the after image.
Solution
I've added a filter to only process includes where
include.fromPath === localPath, ensuring we only fix includes that are directly in the current file.Additional change
I also removed a rogue
publickeyword frombob.ts.