feat(helm): Add azure secret vault integration#3
Open
Conversation
- add go-deploy values files
susilnem
force-pushed
the
feature/setup-secret-vault
branch
from
aa2856e to
5140a65
Compare
thenav56
requested changes
Mar 13, 2026
Member
There was a problem hiding this comment.
Let's break this down into multiple files.
values/
- go-deploy.yaml <--- this will include config for when used with go-deploy
- staging.yaml <--- this will include if any staging scoped application configuration
eg:
https://github.com/IFRCGo/montandon-etl/blob/develop/helm/values/go-deploy.yaml
https://github.com/IFRCGo/montandon-etl/blob/develop/helm/values/staging.yaml
Use XXX: go-deploy to specify this needs to be set in go-deploy. It will help to map variables easily in there
helm/values.yaml
Outdated
Comment on lines
+103
to
+104
| secretsKeyMap: | ||
| TRANSLATION_API_KEY: "TRANSLATION-API-KEY" |
Member
There was a problem hiding this comment.
This should be in the values/go-deploy.yaml (is it depends on how the variables are set in the vault)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses
Changes