Add starting point for supporting provider Descriptive property#15
Add starting point for supporting provider Descriptive property#15adamjarling wants to merge 1 commit intoIIIF-Commons:mainfrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e249cd0:
|
|
@adamjarling I've added a bug to track the linking properties: IIIF-Commons/parser#28 Was able to replicate that here: https://codesandbox.io/s/iiif-builder-forked-rd8b6q?file=/src/index.js I've also added a quick new API here: #16 It allows you to import a block of JSON, like a provider, and it will correctly extract out the various entities etc. const [reference] = this.importRawJson<'Agent'>(singleProvider);
this.modified.add('provider');
this.provider = [...this.provider, reference];So something like this should work, and when the bugs are fixed in the parser, it will output correctly. I do think it would be nice to have an "InstanceBuilder" specifically for the Provider - to help users of the library build good providers with the completion of the APIs. |
|
@stephenwf Ah great. Checking out the PR now... |
What does this do?
A starting point for supporting
provider, and understanding more aboutiiif-builder. In it's current form, it will support aprovider'sMUSTproperties, however it does not handle theSHOULDorMAYproperties:homepagelogoseeAlsoWhen investigating this issue, we realized fully supporting the non MUST properties may require digging deeper into
@iiif/parser,@iiif/presentation-3, and / or@iiif/vault.@stephenwf @mathewjordan Thoughts on how much work this may require? (So we can budget time from now til years end). Thanks!