GlobalScreen: Don't convert mailto:email to http(s)://mailto:email #10748
+9
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @lscharmer as you mentioned #10043, I assume this is also some sort of bug fix. Do we have another issue report in Mantis that you or I can add to this comment?🥴 |
Contributor
Author
Now there is :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The support contact uses
mailto:emailsyntax which is always converted intohttp(s)://hostname:/mailto:emailwhen displayed in the footer under Contact Technical Support which breaks this syntax.This PR changes this, so that the correct URL or
mailto:...value is already returned fromilSystemSupportContactsGUI::getFooterLink(...)(the footer items also supportstringandURI).This PR also fixes #10043 (comment) in ILIAS 12 as the email is not falsely used in the an uri path anymore.