ApacheAuth: Ignore force_login command
#10752
Open
+1
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit suggests ignoring the `force_login` command in the `tryAuthenticationOnLoginPage` function. If the public area is **enabled**, and ILIAS detects that the user has **no valid ILIAS session and access** to the requested resource, an HTTP redirect to the login view with a `cmd=force_login` query parameter will be initiated. This currently leads to a problem where the automatically initiated "Apache Authentication" Single Sign-On will **not** be triggered, even if configured this way. Effect: With this change, requesting the login page with an **enabled** "Apache Authentication" will only be possible **without** triggering the automatically initiated Single Sign-On, if `passed_sso=1` is given in the query parameters (no change was required to achieve this behaviour).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit suggests ignoring the
force_logincommand in the
tryAuthenticationOnLoginPagefunction.If the public area is enabled, and ILIAS detects
that the user has no valid ILIAS session and access
to the requested resource, an HTTP redirect to the
login view with a
cmd=force_loginquery parameterwill be initiated. This currently leads to a problem
where the automatically initiated "Apache Authentication"
Single Sign-On will not be triggered, even if configured
this way.
Side effect of this PR: With this change, requesting the login page with
an enabled "Apache Authentication" will only be possible
without triggering the automatically initiated Single Sign-On,
if
passed_sso=1is given in the query parameters (no change wasrequired to achieve this behaviour).
Commit one has to be picked to
release_10as well, commit two has to be be picked to all maintained branches.