News 47534: Fix Undefined Logger Property#11535
Open
aaronbidzan wants to merge 1 commit intoILIAS-eLearning:release_10from
Open
News 47534: Fix Undefined Logger Property#11535aaronbidzan wants to merge 1 commit intoILIAS-eLearning:release_10from
aaronbidzan wants to merge 1 commit intoILIAS-eLearning:release_10from
Conversation
See: https://mantis.ilias.de/view.php?id=47534 ilNewsForContextBlockGUI used $this->logger when logging errors without declaring or initializing the property, which caused an undefined property notice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix https://mantis.ilias.de/view.php?id=47534.
ilNewsForContextBlockGUI used $this->logger when logging errors without declaring or initializing the property, which caused an undefined property notice.
Kind regards,
@aaronbidzan
/cc @thojou