UI/TagInput: 45566, raw-encode tags

[nhaagen]

https://mantis.ilias.de/view.php?id=45566

[kergomard]

Hi @klees and @nhaagen

Just to put it on the radar: This will collide rather painfully with #9516 .

Thank you very much and best,
@kergomard

[nhaagen]

The relevant changes are mainly outside the js, it will collide, yes, but not that hard :)

[thibsy]

Hi @nhaagen,

Thanks a lot for your contribution to the UI components!

As @kergomard pointed out, this PR conflicts with his PR to introduce auto-completion to the Field\Tag component. He agreed to incorporate your PR into his, since the changes on his end are less trivial and use a different structure. Could you implement the requested changes and pass the PR on to @kergomard once you finished? He will then incorporate and close this PR.

About the concrete changes, please answer the following questions:

• Relevant changes: You have migrated the JavaScript to an ES6 module, thx! To make sure we don't miss any relevant changes, could you point out which changes address the Mantis issue in question? As far as we can see, it should be three rawurlencode() and one encodeURIComponent() function calls.

Please implement the following changes:

• Unit tests: please implement a server-side unit test which covers the bug you are fixing. @kergomard will implement the client-side unit tests inside his new JS structure.

Kind regards,
@thibsy

[kergomard]

Hi @thibsy and @nhaagen

Just to be clear: As far as I understand this, I would just throw away al changes in the Javascript, and only keep the three small changes adding rawurlencode() and rawurldecode() in php. This would mean that the points above would be moot, or am I missing something?

If there is something else to do that I overlooked when I quickly looked at this, I would add it in the implementation I provided for the js, as there the change is far bigger and I would actually simply suggest that I close this PR once I've done so.

Best,
@kergomard

[thibsy]

Hi @kergomard,

There was indeed a misunderstanding. We can continue as you suggested - I updated my review accordingly.

Kind regards,
@thibsy

[nhaagen]

• Relevant changes: You have migrated the JavaScript to an ES6 module, thx! To make sure we don't miss any relevant changes, could you point out which changes address the Mantis issue in question? As far as we can see, it should be three rawurlencode() and one encodeURIComponent() function calls.

For the JS, This encodeURI becomes encodeURIComponent here in transformTag.
The other transforms are in the rendering [1] and transformations [1, 2]

[thibsy]

Thx @nhaagen for providing the PHPUnit test. I approve these changes and let @kergomard incorporate them into his PR.

[thibsy]

Thx @nhaagen, I close this, since it was integrated with #9516 just now.