Fix: Hide sensitive backend configuration errors from user interface#96
Open
Krishanhkr wants to merge 5 commits intoINCF:mainfrom
Open
Fix: Hide sensitive backend configuration errors from user interface#96Krishanhkr wants to merge 5 commits intoINCF:mainfrom
Krishanhkr wants to merge 5 commits intoINCF:mainfrom
Conversation
QuantumByte-01
approved these changes
Mar 19, 2026
Collaborator
QuantumByte-01
left a comment
There was a problem hiding this comment.
Correct fix — the generic message is appropriate and hides internal details from users.
Two notes:
- This PR and PR #92 both modify the same exception handler in
handle_chat— they will conflict. Merge one first. - The existing
print(f"Error in handle_chat: {e}")andtraceback.print_exc()remain. Consider replacing withlogger.exception()in a follow-up to keep logging consistent.
Author
|
"Thanks for the feedback! I have also synced my branch with the latest main. Regarding the conflict with PR #92, I am happy to rebase once #92 is merged, or you can merge this one first as per your preference. Ready for another review!" |
Author
|
Hii, I have resolved the merge conflicts and updated the PR accordingly. Please let me know if any further improvements are needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue of sensitive backend configuration errors being exposed directly to the end-user in the chat UI.
Changes:
Closes #95