fix(ks_search_tool): resolve multiple bugs in ks_search_tool.py (Fixes #73)#98
Open
zohaib-7035 wants to merge 2 commits intoINCF:mainfrom
Open
fix(ks_search_tool): resolve multiple bugs in ks_search_tool.py (Fixes #73)#98zohaib-7035 wants to merge 2 commits intoINCF:mainfrom
zohaib-7035 wants to merge 2 commits intoINCF:mainfrom
Conversation
QuantumByte-01
approved these changes
Mar 19, 2026
Collaborator
QuantumByte-01
left a comment
There was a problem hiding this comment.
All fixes from #73 are correctly addressed:
- Dead
BaseModel/Fieldstubs removed ✅ asyncio.get_event_loop()→asyncio.get_running_loop()✅- All fuzzy matches iterated (not just
matches[0]) ✅ - Warning logged when
datasources_config.jsonis missing ✅ print()→loggingthroughout ✅- Schema unified (
title_guess→title,content→description) ✅
One issue before merge: please remove backend/test_run.py. It's a dev script that makes live network calls — it doesn't belong committed to the repo.
Also note: this PR and PR #97 both modify ks_search_tool.py from the same base — they will conflict. This one should be merged first (after PR #97 is fixed).
Contributor
Author
|
Hi @QuantumByte-01 , The PR should now be ready to merge. Let me know if anything else needs to be addressed! |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the multiple issues identified in Issue #73 regarding
ks_search_tool.py.Changes Made:
BaseModelandFieldleftovers from removing Pydantic.general_searchand_perform_searchnow return consistent_id,title,descriptionfields.global_fuzzy_keyword_searchnow logs a warning whendatasources_config.jsonis missing.search_across_all_fieldsnow iterates over all matches instead of onlymatches[0].asyncio.get_event_loop()withasyncio.get_running_loop().print()→logging: Replaced all 10+ print calls withlogger.info()/logger.error().test_run.pyfor renamed field (title_guess→title).Verification
Fixes #73