Skip to content

Remove transform to markdown from Get Collection use case #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ofahimIQSS merged 2 commits into from
Feb 21, 2025
Merged

Remove transform to markdown from Get Collection use case #265

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8530dcb
feat: remove transform to markdown from Get Collection use case
ekraffmiller Feb 19, 2025
700ed8c
test: fix due to receiving items in different order
g-saracca Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/collections/infra/repositories/transformers/collectionTransformers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import {
CollectionPayload
} from './CollectionPayload'
import { transformPayloadToOwnerNode } from '../../../../core/infra/repositories/transformers/dvObjectOwnerNodeTransformer'
import { transformHtmlToMarkdown } from '../../../../datasets/infra/repositories/transformers/datasetTransformers'
import { CollectionFacet } from '../../../domain/models/CollectionFacet'
import { CollectionFacetPayload } from './CollectionFacetPayload'
import {
Expand Down Expand Up @@ -53,9 +52,7 @@ const transformPayloadToCollection = (collectionPayload: CollectionPayload): Col
type: collectionPayload.dataverseType as CollectionType,
isMetadataBlockRoot: collectionPayload.isMetadataBlockRoot,
isFacetRoot: collectionPayload.isFacetRoot,
...(collectionPayload.description && {
description: transformHtmlToMarkdown(collectionPayload.description)
}),
description: collectionPayload.description,
Comment thread
g-saracca marked this conversation as resolved.
...(collectionPayload.isPartOf && {
isPartOf: transformPayloadToOwnerNode(collectionPayload.isPartOf)
}),
Expand Down
7 changes: 3 additions & 4 deletions test/testHelpers/collections/collectionHelper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,7 @@ const COLLECTION_ALIAS_STR = 'secondCollection'
const COLLECTION_NAME_STR = 'Laboratory Research'
const COLLECTION_AFFILIATION_STR = 'Laboratory Research Corporation'

const COLLECTION_DESCRIPTION_HTML = 'This is an <b>example</b> collection used for testing.'
const COLLECTION_DESCRIPTION_MARKDOWN = 'This is an **example** collection used for testing.'
const COLLECTION_DESCRIPTION = 'This is an <b>example</b> collection used for testing.'

const DATAVERSE_API_REQUEST_HEADERS = {
headers: { 'Content-Type': 'application/json', 'X-Dataverse-Key': process.env.TEST_API_KEY }
Expand All @@ -30,7 +29,7 @@ export const createCollectionModel = (): Collection => {
name: COLLECTION_NAME_STR,
isReleased: COLLECTION_IS_RELEASED,
affiliation: COLLECTION_AFFILIATION_STR,
description: COLLECTION_DESCRIPTION_MARKDOWN,
description: COLLECTION_DESCRIPTION,
isPartOf: { type: DvObjectType.DATAVERSE, identifier: 'root', displayName: 'Root' },
inputLevels: [
{
Expand Down Expand Up @@ -59,7 +58,7 @@ export const createCollectionPayload = (): CollectionPayload => {
name: COLLECTION_NAME_STR,
isReleased: COLLECTION_IS_RELEASED,
affiliation: COLLECTION_AFFILIATION_STR,
description: COLLECTION_DESCRIPTION_HTML,
description: COLLECTION_DESCRIPTION,
isPartOf: { type: DvObjectType.DATAVERSE, identifier: 'root', displayName: 'Root' },
inputLevels: [
{
Expand Down