Ensure forward compatibility with ipl-orm by adding return types#72
Merged
Ensure forward compatibility with ipl-orm by adding return types#72
ipl-orm by adding return types#72Conversation
BastianLedererIcinga
force-pushed
the
modernize-code
branch
from
db52492 to
57b2043
Compare
Add return types in subclasses of `UnionModel` to ensure compatibility with ipl-orm.
BastianLedererIcinga
force-pushed
the
modernize-code
branch
from
57b2043 to
9c758e2
Compare
sukhwinder33445
approved these changes
Mar 4, 2026
17 tasks
lippserd
changed the title
ipl forward compatibilityipl-orm by adding return types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce explicit return types in subclasses of
UnionModelto prepare forstrict typing in
ipl-orm. These additions are safe, as they only define returnsignatures where none existed before.
refs Icinga/ipl-orm#158