Skip to content

fix: 解决移动端适配问题 #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ImXiangYu merged 1 commit into from
Mar 9, 2026
Merged

fix: 解决移动端适配问题 #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 31 additions & 21 deletions better-github-nav.user.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// @name Better GitHub Navigation
// @name:zh-CN 更好的 GitHub 导航栏
// @namespace https://github.com/ImXiangYu/better-github-nav
// @version 0.1.44
// @version 0.1.45
// @description Bring Dashboard, Trending, Explore, Collections, and Stars closer on desktop and narrow screens, and keep your most-used repositories pinned where they are easiest to reach.
// @description:zh-CN 在桌面端和窄屏场景下，把 Dashboard、Trending、Explore、Collections、Stars 放到更顺手的位置，并把你最常用的仓库固定在最容易到达的地方。
// @author Ayubass
Expand All @@ -16,7 +16,7 @@

(() => {
// src/constants.js
var SCRIPT_VERSION = "0.1.44";
var SCRIPT_VERSION = "0.1.45";
var CUSTOM_BUTTON_CLASS = "custom-gh-nav-btn";
var CUSTOM_BUTTON_ACTIVE_CLASS = "custom-gh-nav-btn-active";
var CUSTOM_BUTTON_COMPACT_CLASS = "custom-gh-nav-btn-compact";
Expand Down Expand Up @@ -242,8 +242,8 @@
transform: rotate(180deg);
}
.custom-gh-nav-overflow-menu {
position: absolute;
top: calc(100% + 8px);
position: fixed;
top: 0;
left: 0;
z-index: 2147483646;
display: flex;
Expand Down Expand Up @@ -545,13 +545,6 @@
margin: 6px 0;
background: var(--color-border-muted, rgba(208, 215, 222, 0.8));
}
@media (max-width: 767px) {
.custom-gh-nav-overflow-menu {
left: auto;
right: 0;
min-width: min(240px, calc(100vw - 16px));
}
}
`;
document.head.appendChild(style);
}
Expand Down Expand Up @@ -723,25 +716,37 @@
state.toggleButton.setAttribute("aria-expanded", state.menuOpen ? "true" : "false");
}
function positionResponsiveQuickLinksMenu(state) {
state.menuNode.style.left = "0";
state.menuNode.style.right = "auto";
const rect = state.menuNode.getBoundingClientRect();
const viewportPadding = 8;
if (rect.right > window.innerWidth - viewportPadding) {
state.menuNode.style.left = "auto";
state.menuNode.style.right = "0";
}
if (state.menuNode.getBoundingClientRect().left < viewportPadding) {
state.menuNode.style.left = "0";
state.menuNode.style.right = "auto";
const anchorRect = state.toggleButton.getBoundingClientRect();
state.menuNode.style.left = `${viewportPadding}px`;
state.menuNode.style.top = `${Math.round(anchorRect.bottom + viewportPadding)}px`;
const menuRect = state.menuNode.getBoundingClientRect();
const maxLeft = Math.max(viewportPadding, window.innerWidth - menuRect.width - viewportPadding);
const preferredLeft = anchorRect.right - menuRect.width;
const fallbackLeft = anchorRect.left;
const unclampedLeft = preferredLeft >= viewportPadding ? preferredLeft : fallbackLeft;
const left = Math.min(maxLeft, Math.max(viewportPadding, unclampedLeft));
let top = anchorRect.bottom + viewportPadding;
const fitsBelow = top + menuRect.height <= window.innerHeight - viewportPadding;
const fitsAbove = anchorRect.top - viewportPadding - menuRect.height >= viewportPadding;
if (!fitsBelow && fitsAbove) {
top = anchorRect.top - viewportPadding - menuRect.height;
} else if (!fitsBelow) {
top = Math.max(
viewportPadding,
window.innerHeight - menuRect.height - viewportPadding
);
}
state.menuNode.style.left = `${Math.round(left)}px`;
state.menuNode.style.top = `${Math.round(top)}px`;
}
function closeResponsiveQuickLinksMenu() {
const state = responsiveQuickLinksState;
if (!state || !state.menuOpen) return;
hideHotkeyTooltip();
state.menuOpen = false;
state.menuNode.hidden = true;
state.menuNode.style.visibility = "";
updateResponsiveQuickLinksToggle(state);
}
function toggleResponsiveQuickLinksMenu() {
Expand All @@ -751,7 +756,9 @@
state.menuOpen = !state.menuOpen;
state.menuNode.hidden = !state.menuOpen;
if (state.menuOpen) {
state.menuNode.style.visibility = "hidden";
positionResponsiveQuickLinksMenu(state);
state.menuNode.style.visibility = "";
}
updateResponsiveQuickLinksToggle(state);
}
Expand Down Expand Up @@ -852,6 +859,9 @@
if (target && state.toggleHostNode.contains(target)) return;
closeResponsiveQuickLinksMenu();
}, true);
document.addEventListener("scroll", () => {
closeResponsiveQuickLinksMenu();
}, true);
}
function setupResponsiveQuickLinks({
renderParent,
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "better-github-nav",
"version": "0.1.44",
"version": "0.1.45",
"description": "Bring Dashboard, Trending, Explore, Collections, and Stars closer on desktop and narrow screens, and keep your most-used repositories pinned where they are easiest to reach.",
"private": true,
"scripts": {
Expand Down
44 changes: 32 additions & 12 deletions src/navigation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,20 +194,33 @@ function updateResponsiveQuickLinksToggle(state) {
}

function positionResponsiveQuickLinksMenu(state) {
state.menuNode.style.left = '0';
state.menuNode.style.right = 'auto';

const rect = state.menuNode.getBoundingClientRect();
const viewportPadding = 8;

if (rect.right > window.innerWidth - viewportPadding) {
state.menuNode.style.left = 'auto';
state.menuNode.style.right = '0';
}
if (state.menuNode.getBoundingClientRect().left < viewportPadding) {
state.menuNode.style.left = '0';
state.menuNode.style.right = 'auto';
const anchorRect = state.toggleButton.getBoundingClientRect();

state.menuNode.style.left = `${viewportPadding}px`;
state.menuNode.style.top = `${Math.round(anchorRect.bottom + viewportPadding)}px`;

const menuRect = state.menuNode.getBoundingClientRect();
const maxLeft = Math.max(viewportPadding, window.innerWidth - menuRect.width - viewportPadding);
const preferredLeft = anchorRect.right - menuRect.width;
const fallbackLeft = anchorRect.left;
const unclampedLeft = preferredLeft >= viewportPadding ? preferredLeft : fallbackLeft;
const left = Math.min(maxLeft, Math.max(viewportPadding, unclampedLeft));

let top = anchorRect.bottom + viewportPadding;
const fitsBelow = top + menuRect.height <= window.innerHeight - viewportPadding;
const fitsAbove = anchorRect.top - viewportPadding - menuRect.height >= viewportPadding;
if (!fitsBelow && fitsAbove) {
top = anchorRect.top - viewportPadding - menuRect.height;
} else if (!fitsBelow) {
top = Math.max(
viewportPadding,
window.innerHeight - menuRect.height - viewportPadding
);
}

state.menuNode.style.left = `${Math.round(left)}px`;
state.menuNode.style.top = `${Math.round(top)}px`;
}

function closeResponsiveQuickLinksMenu() {
Expand All @@ -217,6 +230,7 @@ function closeResponsiveQuickLinksMenu() {
hideHotkeyTooltip();
state.menuOpen = false;
state.menuNode.hidden = true;
state.menuNode.style.visibility = '';
updateResponsiveQuickLinksToggle(state);
}

Expand All @@ -228,7 +242,9 @@ function toggleResponsiveQuickLinksMenu() {
state.menuOpen = !state.menuOpen;
state.menuNode.hidden = !state.menuOpen;
if (state.menuOpen) {
state.menuNode.style.visibility = 'hidden';
positionResponsiveQuickLinksMenu(state);
state.menuNode.style.visibility = '';
}
updateResponsiveQuickLinksToggle(state);
}
Expand Down Expand Up @@ -354,6 +370,10 @@ function bindResponsiveQuickLinksGlobalHandlers() {
if (target && state.toggleHostNode.contains(target)) return;
closeResponsiveQuickLinksMenu();
}, true);

document.addEventListener('scroll', () => {
closeResponsiveQuickLinksMenu();
}, true);
}

function setupResponsiveQuickLinks({
Expand Down
11 changes: 2 additions & 9 deletions src/styles.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,8 @@ export function ensureStyles() {
transform: rotate(180deg);
}
.custom-gh-nav-overflow-menu {
position: absolute;
top: calc(100% + 8px);
position: fixed;
top: 0;
left: 0;
z-index: 2147483646;
display: flex;
Expand Down Expand Up @@ -377,13 +377,6 @@ export function ensureStyles() {
margin: 6px 0;
background: var(--color-border-muted, rgba(208, 215, 222, 0.8));
}
@media (max-width: 767px) {
.custom-gh-nav-overflow-menu {
left: auto;
right: 0;
min-width: min(240px, calc(100vw - 16px));
}
}
`;
document.head.appendChild(style);
}
Expand Down