Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
DateTime.Nowusage andDateTimeglobals with UTC tick-based atomic storage to avoid race conditions and timezone/clock issues in startup and watchdog logic.Description
DateTimefields (lastHeartbeat,splashScreenStartTime,appStartupStartTime,startupCompleteHeartbeat) with UTC ticklongfields (lastHeartbeatTicksUtc,splashScreenStartTimeTicksUtc,appStartupStartTimeTicksUtc) and useInterlocked.Exchange/Interlocked.Readfor thread-safe updates and reads.DateTime.NowtoDateTime.UtcNowand store ticks to the new atomic fields (e.g. when showing splash and at app startup).ReadUtcTicksto convert stored ticks back toDateTimewithDateTimeKind.Utcand to interpret default values asDateTime.MinValue.heartbeatTimerandwatchdogTimerlogic to use atomic tick reads andDateTime.UtcNowto compute elapsed times and decide on silent restarts.Testing
Codex Task