S3 Features Overhaul 🚀 by garronej · Pull Request #1057 · InseeFrLab/onyxia

garronej · 2026-02-15T23:15:58Z

No description provided.

coderabbitai · 2026-02-15T23:16:07Z

Important

Review skipped

Too many files!

This PR contains 205 files, which is 55 over the limit of 150.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: aac7bfbe-65f4-4409-8ab3-7f7c981d6193

📥 Commits

Reviewing files that changed from the base of the PR and between 038993c and c42d4da.

⛔ Files ignored due to path filters (3)

web/src/ui/assets/svg/S3UriBucket.svg is excluded by !**/*.svg
web/src/ui/assets/svg/S3UriHome.svg is excluded by !**/*.svg
web/yarn.lock is excluded by !**/yarn.lock, !**/*.lock

📒 Files selected for processing (205)

.vscode/mcp.json
web/.env
web/package.json
web/spec.md
web/src/core/adapters/onyxiaApi/ApiTypes.ts
web/src/core/adapters/onyxiaApi/onyxiaApi.ts
web/src/core/adapters/s3Client/s3Client.ts
web/src/core/adapters/s3Client/utils/bucketNameAndObjectNameFromS3Path.ts
web/src/core/adapters/s3Client/utils/bucketPolicy.test.ts
web/src/core/adapters/s3Client/utils/bucketPolicy.ts
web/src/core/adapters/s3Client/utils/policySchema.ts
web/src/core/adapters/sqlOlap/sqlOlap.ts
web/src/core/bootstrap.ts
web/src/core/ports/OnyxiaApi/DeploymentRegion.ts
web/src/core/ports/OnyxiaApi/XOnyxia.ts
web/src/core/ports/S3Client.ts
web/src/core/tools/S3Uri.test.ts
web/src/core/tools/S3Uri.ts
web/src/core/usecases/fileExplorer/selectors.ts
web/src/core/usecases/fileExplorer/state.ts
web/src/core/usecases/fileExplorer/thunks.ts
web/src/core/usecases/index.ts
web/src/core/usecases/launcher/selectors.ts
web/src/core/usecases/launcher/state.ts
web/src/core/usecases/launcher/thunks.ts
web/src/core/usecases/projectManagement/decoupledLogic/ProjectConfigs.ts
web/src/core/usecases/projectManagement/decoupledLogic/clearProjectConfigs.ts
web/src/core/usecases/projectManagement/decoupledLogic/projectConfigsMigration/index.ts
web/src/core/usecases/projectManagement/decoupledLogic/projectConfigsMigration/projectConfigsMigration.ts
web/src/core/usecases/projectManagement/decoupledLogic/projectConfigsMigration/v0ToV1.ts
web/src/core/usecases/projectManagement/thunks.ts
web/src/core/usecases/restorableConfigManagement/decoupledLogic/getAreSameRestorableConfig.ts
web/src/core/usecases/restorableConfigManagement/selectors.ts
web/src/core/usecases/restorableConfigManagement/thunks.ts
web/src/core/usecases/s3CodeSnippets/selectors.ts
web/src/core/usecases/s3CodeSnippets/thunks.ts
web/src/core/usecases/s3ConfigConnectionTest/selectors.ts
web/src/core/usecases/s3ConfigConnectionTest/state.ts
web/src/core/usecases/s3ConfigConnectionTest/thunks.ts
web/src/core/usecases/s3ConfigCreation/selectors.ts
web/src/core/usecases/s3ConfigCreation/thunks.ts
web/src/core/usecases/s3ConfigManagement/decoupledLogic/getS3Configs.ts
web/src/core/usecases/s3ConfigManagement/decoupledLogic/getWorkingDirectoryBucket.ts
web/src/core/usecases/s3ConfigManagement/decoupledLogic/getWorkingDirectoryPath.ts
web/src/core/usecases/s3ConfigManagement/decoupledLogic/projectS3ConfigId.ts
web/src/core/usecases/s3ConfigManagement/decoupledLogic/resolveS3AdminBookmarks.ts
web/src/core/usecases/s3ConfigManagement/decoupledLogic/updateDefaultS3ConfigsAfterPotentialDeletion.ts
web/src/core/usecases/s3ConfigManagement/index.ts
web/src/core/usecases/s3ConfigManagement/selectors.ts
web/src/core/usecases/s3ConfigManagement/state.ts
web/src/core/usecases/s3ConfigManagement/thunks.ts
web/src/core/usecases/s3ExplorerUiController/decoupledLogic/computeUploadStatusAtPrefix.ts
web/src/core/usecases/s3ExplorerUiController/decoupledLogic/uploadProgress.ts
web/src/core/usecases/s3ExplorerUiController/evt.ts
web/src/core/usecases/s3ExplorerUiController/index.ts
web/src/core/usecases/s3ExplorerUiController/selectors.ts
web/src/core/usecases/s3ExplorerUiController/state.ts
web/src/core/usecases/s3ExplorerUiController/thunks.ts
web/src/core/usecases/s3ProfilesCreationUiController/index.ts
web/src/core/usecases/s3ProfilesCreationUiController/selectors.ts
web/src/core/usecases/s3ProfilesCreationUiController/state.ts
web/src/core/usecases/s3ProfilesCreationUiController/thunks.ts
web/src/core/usecases/s3ProfilesManagement/decoupledLogic/resolveTemplatedBookmark.ts
web/src/core/usecases/s3ProfilesManagement/decoupledLogic/resolveTemplatedStsRole.ts
web/src/core/usecases/s3ProfilesManagement/decoupledLogic/s3Profiles.ts
web/src/core/usecases/s3ProfilesManagement/decoupledLogic/userConfigsS3Bookmarks.ts
web/src/core/usecases/s3ProfilesManagement/index.ts
web/src/core/usecases/s3ProfilesManagement/selectors.ts
web/src/core/usecases/s3ProfilesManagement/state.ts
web/src/core/usecases/s3ProfilesManagement/thunks.ts
web/src/core/usecases/userConfigs.ts
web/src/core/usecases/userProfileForm/thunks.ts
web/src/ui/App/App.tsx
web/src/ui/App/LeftBar.tsx
web/src/ui/i18n/resources/de.tsx
web/src/ui/i18n/resources/en.tsx
web/src/ui/i18n/resources/es.tsx
web/src/ui/i18n/resources/fi.tsx
web/src/ui/i18n/resources/fr.tsx
web/src/ui/i18n/resources/it.tsx
web/src/ui/i18n/resources/nl.tsx
web/src/ui/i18n/resources/no.tsx
web/src/ui/i18n/resources/zh-CN.tsx
web/src/ui/i18n/types.ts
web/src/ui/pages/dataExplorer/DataGrid.tsx
web/src/ui/pages/dataExplorer/Page.tsx
web/src/ui/pages/fileExplorer/Explorer/Explorer.tsx
web/src/ui/pages/fileExplorer/Explorer/ExplorerButtonBar.stories.tsx
web/src/ui/pages/fileExplorer/Explorer/ExplorerButtonBar.tsx
web/src/ui/pages/fileExplorer/Explorer/ExplorerDownloadSnackbar.tsx
web/src/ui/pages/fileExplorer/Explorer/ExplorerIcon/ExplorerIcon.stories.tsx
web/src/ui/pages/fileExplorer/Explorer/ExplorerIcon/ExplorerIcon.tsx
web/src/ui/pages/fileExplorer/Explorer/ExplorerIcon/icons.ts
web/src/ui/pages/fileExplorer/Explorer/ExplorerIcon/index.ts
web/src/ui/pages/fileExplorer/Explorer/ExplorerItems/ExplorerItem.stories.tsx
web/src/ui/pages/fileExplorer/Explorer/ExplorerItems/ExplorerItem.tsx
web/src/ui/pages/fileExplorer/Explorer/ExplorerItems/ExplorerItems.stories.tsx
web/src/ui/pages/fileExplorer/Explorer/ExplorerItems/ExplorerItems.tsx
web/src/ui/pages/fileExplorer/Explorer/ExplorerItems/index.ts
web/src/ui/pages/fileExplorer/Explorer/ExplorerUploadModal/ExplorerUploadModal.stories.tsx
web/src/ui/pages/fileExplorer/Explorer/ExplorerUploadModal/ExplorerUploadModal.tsx
web/src/ui/pages/fileExplorer/Explorer/ExplorerUploadModal/ExplorerUploadModalDropArea.stories.tsx
web/src/ui/pages/fileExplorer/Explorer/ExplorerUploadModal/ExplorerUploadModalDropArea.tsx
web/src/ui/pages/fileExplorer/Explorer/ExplorerUploadModal/ExplorerUploadProgress.stories.tsx
web/src/ui/pages/fileExplorer/Explorer/ExplorerUploadModal/ExplorerUploadProgress.tsx
web/src/ui/pages/fileExplorer/Explorer/ExplorerUploadModal/index.ts
web/src/ui/pages/fileExplorer/Explorer/ListExplorer/ListExplorerItems.stories.tsx
web/src/ui/pages/fileExplorer/Explorer/ListExplorer/ListExplorerItems.tsx
web/src/ui/pages/fileExplorer/Explorer/PolicySwitch.stories.tsx
web/src/ui/pages/fileExplorer/Explorer/PolicySwitch.tsx
web/src/ui/pages/fileExplorer/Explorer/index.ts
web/src/ui/pages/fileExplorer/Page.tsx
web/src/ui/pages/fileExplorer/ShareFile/SelectTime.stories.tsx
web/src/ui/pages/fileExplorer/ShareFile/SelectTime.tsx
web/src/ui/pages/fileExplorer/ShareFile/ShareDialog.stories.tsx
web/src/ui/pages/fileExplorer/ShareFile/ShareDialog.tsx
web/src/ui/pages/fileExplorer/route.ts
web/src/ui/pages/fileExplorer/shared/DirectoryOrFileDetailed.stories.tsx
web/src/ui/pages/fileExplorer/shared/DirectoryOrFileDetailed.tsx
web/src/ui/pages/fileExplorer/shared/tools.ts
web/src/ui/pages/fileExplorer/shared/types.ts
web/src/ui/pages/fileExplorerEntry/FileExplorerDisabledDialog.stories.tsx
web/src/ui/pages/fileExplorerEntry/FileExplorerDisabledDialog.tsx
web/src/ui/pages/fileExplorerEntry/Page.tsx
web/src/ui/pages/fileExplorerEntry/S3Entries/S3Entries.tsx
web/src/ui/pages/fileExplorerEntry/S3Entries/S3EntryCard.tsx
web/src/ui/pages/fileExplorerEntry/index.ts
web/src/ui/pages/fileExplorerEntry/route.ts
web/src/ui/pages/home/Page.tsx
web/src/ui/pages/index.ts
web/src/ui/pages/launcher/LauncherMainCard.tsx
web/src/ui/pages/launcher/Page.tsx
web/src/ui/pages/mySecrets/SecretsExplorer/SecretsExplorer.tsx
web/src/ui/pages/myService/Page.tsx
web/src/ui/pages/myServices/Page.tsx
web/src/ui/pages/projectSettings/Page.tsx
web/src/ui/pages/projectSettings/ProjectSettingsS3ConfigTab/ProjectSettingsS3ConfigTab.tsx
web/src/ui/pages/projectSettings/ProjectSettingsS3ConfigTab/S3ConfigCard.tsx
web/src/ui/pages/projectSettings/ProjectSettingsS3ConfigTab/S3ConfigDialogs/ConfirmCustomS3ConfigDeletionDialog.stories.tsx
web/src/ui/pages/projectSettings/ProjectSettingsS3ConfigTab/S3ConfigDialogs/S3ConfigDialogs.tsx
web/src/ui/pages/projectSettings/ProjectSettingsS3ConfigTab/S3ConfigDialogs/index.ts
web/src/ui/pages/projectSettings/ProjectSettingsS3ConfigTab/TestS3ConnectionButton.stories.tsx
web/src/ui/pages/projectSettings/ProjectSettingsS3ConfigTab/TestS3ConnectionButton.tsx
web/src/ui/pages/projectSettings/ProjectSettingsS3ConfigTab/index.ts
web/src/ui/pages/projectSettings/ProjectSettingsSecurityInfosTab.tsx
web/src/ui/pages/projectSettings/index.ts
web/src/ui/pages/projectSettings/route.ts
web/src/ui/pages/projectSettings/tabIds.ts
web/src/ui/pages/s3Explorer/Page.tsx
web/src/ui/pages/s3Explorer/Uploads.tsx
web/src/ui/pages/s3Explorer/dialogs/ConfirmBucketCreationAttemptDialog.tsx
web/src/ui/pages/s3Explorer/dialogs/ConfirmCustomS3ConfigDeletionDialog.tsx
web/src/ui/pages/s3Explorer/dialogs/CreateOrRenameBookmarkDialog.tsx
web/src/ui/pages/s3Explorer/dialogs/CreateOrUpdateProfileDialog.tsx
web/src/ui/pages/s3Explorer/dialogs/S3ExplorerDialogs.tsx
web/src/ui/pages/s3Explorer/dialogs/index.ts
web/src/ui/pages/s3Explorer/index.ts
web/src/ui/pages/s3Explorer/route.ts
web/src/ui/shared/CommandBar.stories.tsx
web/src/ui/shared/CommandBar.tsx
web/src/ui/shared/Datagrid/CustomNoRowsOverlay.tsx
web/src/ui/shared/MaybeAcknowledgeConfigVolatilityDialog.tsx
web/src/ui/shared/codex/CreateS3ProfileModal/CreateS3ProfileModal.spec.md
web/src/ui/shared/codex/CreateS3ProfileModal/CreateS3ProfileModal.stories.tsx
web/src/ui/shared/codex/CreateS3ProfileModal/CreateS3ProfileModal.tsx
web/src/ui/shared/codex/CreateS3ProfileModal/index.ts
web/src/ui/shared/codex/S3Bookmarks/S3BookmarksBar/S3BookmarksBar.spec.md
web/src/ui/shared/codex/S3Bookmarks/S3BookmarksBar/S3BookmarksBar.stories.tsx
web/src/ui/shared/codex/S3Bookmarks/S3BookmarksBar/S3BookmarksBar.tsx
web/src/ui/shared/codex/S3Bookmarks/S3BookmarksBar/index.ts
web/src/ui/shared/codex/S3Bookmarks/S3BookmarksBarItem/S3BookmarksBarItem.spec.md
web/src/ui/shared/codex/S3Bookmarks/S3BookmarksBarItem/S3BookmarksBarItem.tsx
web/src/ui/shared/codex/S3Bookmarks/S3BookmarksBarItem/index.ts
web/src/ui/shared/codex/S3Bookmarks/S3BookmarksEntryPointItem/S3BookmarksEntryPointItem.spec.md
web/src/ui/shared/codex/S3Bookmarks/S3BookmarksEntryPointItem/S3BookmarksEntryPointItem.stories.tsx
web/src/ui/shared/codex/S3Bookmarks/S3BookmarksEntryPointItem/S3BookmarksEntryPointItem.tsx
web/src/ui/shared/codex/S3Bookmarks/S3BookmarksEntryPointItem/index.ts
web/src/ui/shared/codex/S3ContextActionButton/S3ContextActionButton.spec.md
web/src/ui/shared/codex/S3ContextActionButton/S3ContextActionButton.stories.tsx
web/src/ui/shared/codex/S3ContextActionButton/S3ContextActionButton.tsx
web/src/ui/shared/codex/S3ContextActionButton/index.ts
web/src/ui/shared/codex/S3ExplorerMainView/S3ExplorerMainView.spec.md
web/src/ui/shared/codex/S3ExplorerMainView/S3ExplorerMainView.stories.tsx
web/src/ui/shared/codex/S3ExplorerMainView/S3ExplorerMainView.tsx
web/src/ui/shared/codex/S3ExplorerMainView/index.ts
web/src/ui/shared/codex/S3ProfileSelect/S3ProfilSelect.spec.md
web/src/ui/shared/codex/S3ProfileSelect/S3ProfileSelect.stories.tsx
web/src/ui/shared/codex/S3ProfileSelect/S3ProfileSelect.tsx
web/src/ui/shared/codex/S3ProfileSelect/index.ts
web/src/ui/shared/codex/S3SelectionActionBar/S3SelectionActionBar.spec.md
web/src/ui/shared/codex/S3SelectionActionBar/S3SelectionActionBar.stories.tsx
web/src/ui/shared/codex/S3SelectionActionBar/S3SelectionActionBar.tsx
web/src/ui/shared/codex/S3SelectionActionBar/index.ts
web/src/ui/shared/codex/S3Uploads/ConfirmAbortUploadDialog.tsx
web/src/ui/shared/codex/S3Uploads/S3Upload.spec.md
web/src/ui/shared/codex/S3Uploads/S3Upload.stories.tsx
web/src/ui/shared/codex/S3Uploads/S3Upload.tsx
web/src/ui/shared/codex/S3Uploads/index.ts
web/src/ui/shared/codex/S3UriBar/S3UriBar.spec.md
web/src/ui/shared/codex/S3UriBar/S3UriBar.stories.tsx
web/src/ui/shared/codex/S3UriBar/S3UriBar.tsx
web/src/ui/shared/codex/S3UriBar/index.ts
web/src/ui/shared/codex/general.spec.md
web/src/ui/theme/theme.tsx
web/src/ui/tools/withLoader.tsx

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch explorer_deep_rework

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

…orted.

…), adjust spacing bookmarks

sonarqubecloud · 2026-04-03T03:04:43Z

Quality Gate failed

Failed conditions
2 Security Hotspots
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

garronej added 18 commits February 4, 2026 17:26

Centralize checks

e51e774

Checkpoint

99891a7

Merge explorer and explorer controller into a single usecase

163dd25

Move the thunks to the correct location

673ab3c

Refactor

ef9a2d2

Repatiate bookmark status in s3ExplorerUiController usecase

8229e8d

Fix a lot of type errors, ensuring consistency across the codebase

dd94f33

Fix last remaining type error, it compiles!

0e21ae5

Remove comment

f0b04bf

Fix anteriority violation

2441594

Fix type error

fa05589

Fixes errors related to s3 uri parsing

8228e41

Fix bug in profile navigation

5fe96d4

Forgot to dispatch an action

ed095fd

Forgot to dispatch (2)

a8b53a5

Fix navigation issue in explorer

204d7f9

Explorer usecase duplicate

3c1944b

Firs step in overhauling the core of the s3 explorer

212b038

garronej added 11 commits February 16, 2026 17:10

Checkpoint

eff4c5f

Progress...

e360590

Checkpoint

1e453f8

Reactive refresh on download complete

5e2a921

Implement createDirectory using putObjects

29465ca

Create simplified version of the s3 port

f428848

Update S3Uri utils

4b9c6bf

Move to new, partial implementation of the s3 port

0ccaf22

Implement proper delete and bulk delete approach

eed85ab

Implement get presigned url

68429bc

remove unused import

f26c4bd

marchufschmitt and others added 11 commits March 26, 2026 12:59

S3Upload Details UI Upgrade + add collapsed interaction

75c0582

Change Upload Zone Size and upgrade UI and content info

762c0ac

Upload Integration

1a031d8

Fix build

618a347

Fix layout shift

b9ba3de

Add padding to avoid shadow clipping

ff3e65d

We need space below the main view to show the data grid.

c8f53ab

Enable to upload directory

95088ca

Make sure that when a download has been cancel, progress can't be rep…

f117e81

…orted.

Cancel command when upload has been canceled

e265511

Enable to 'delete' ongoing uploads (it cancels)

b9d1004

garronej force-pushed the explorer_deep_rework branch from 4db9915 to b9d1004 Compare March 31, 2026 05:46

marchufschmitt and others added 17 commits March 31, 2026 14:24

S3Upload Component - UI Update : spacing, icons and upload gauge

44d1394

Update specs with new ui changes of S3upload component

7070b9a

S3ExplorerMainView : Add surface background on headerRow

c847e1d

Define min width for the open modal of S3ProfileSelect component (UI)

87dcfb7

Proper error handling on failed uploads

c7c83a0

Implement a queue for file uploads, can only upload one file at the time

ca9f7f0

Create new compoent S3ContextActionButton with spec and story

22054ad

Update upload ui component to align with how Google Drive does it

304a8ae

Implement error upload retry

f84915c

Fix putObject cancel logic

63801cc

core: Cancel and retry uploads

f105438

Introduce upload status modal global to the app UI

cd804d2

Keep completed uploads in the list

17dadde

Sort file upload alphabetically

6665e97

Avoid layout shift on uploads

0c9c56f

Integrate navigate back button

6b683b6

Integrate S3 bar buttons for creating a dir and uploading a file (WIP…

c42d4da

…), adjust spacing bookmarks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

S3 Features Overhaul 🚀#1057

S3 Features Overhaul 🚀#1057
garronej wants to merge 309 commits intomainfrom
explorer_deep_rework

garronej commented Feb 15, 2026

Uh oh!

coderabbitai bot commented Feb 15, 2026 •

edited

Loading

Review skipped

Uh oh!

sonarqubecloud bot commented Apr 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

garronej commented Feb 15, 2026

Uh oh!

coderabbitai bot commented Feb 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

sonarqubecloud bot commented Apr 3, 2026

Quality Gate failed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

coderabbitai bot commented Feb 15, 2026 •

edited

Loading