Fix issue where binds = [] has no effect#313
Closed
mori-atsushi wants to merge 1 commit intoInsertKoinIO:2.3.0from
Closed
Fix issue where binds = [] has no effect#313mori-atsushi wants to merge 1 commit intoInsertKoinIO:2.3.0from
mori-atsushi wants to merge 1 commit intoInsertKoinIO:2.3.0from
Conversation
Remove isNotEmpty() check from forceDeclaredBindings condition to allow binds=[] to work as intended. Previously, empty binds array was treated as default binding due to the isEmpty check, preventing users from explicitly disabling bindings.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Single(binds = [])and@Factory(binds = [])are expected to clear all bindings,but currently, all supertypes are still registered.
To resolve this, remove the
isNotEmpty()check from theforceDeclaredBindingsconditionso that an empty binds array works as intended.